Skip to content

Commit 44d59a0

Browse files
committed
internal/gaby: actually run github.Add
I don't know why but currently gabby does not call github.Add. And make github.Add no-op if the project is already present in DB (like CL 627778) For #51 Change-Id: I9d3760bad50186a2f03e20f46d76ef164ac675f3 Reviewed-on: https://go-review.googlesource.com/c/oscar/+/629355 Reviewed-by: Zvonimir Pavlinovic <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 61d708c commit 44d59a0

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

internal/gaby/main.go

+5
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,11 @@ func main() {
122122
defer shutdown()
123123

124124
g.github = github.New(g.slog, g.db, g.secret, g.http)
125+
for _, project := range g.githubProjects {
126+
if err := g.github.Add(project); err != nil {
127+
log.Fatalf("github.Add failed: %v", err)
128+
}
129+
}
125130
g.disc = discussion.New(g.ctx, g.slog, g.secret, g.db)
126131
for _, project := range g.githubProjects {
127132
if err := g.disc.Add(project); err != nil {

internal/github/sync.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,11 @@ func (proj *projectSync) store(db storage.DB) {
155155
// to the database.
156156
// It only adds the project sync metadata.
157157
// The initial data fetch does not happen until [Sync] or [SyncProject] is called.
158-
// Add returns an error if the project has already been added.
158+
// If the project is already present, Add does nothing and returns nil.
159159
func (c *Client) Add(project string) error {
160160
key := o(syncProjectKind, project)
161161
if _, ok := c.db.Get(key); ok {
162-
return fmt.Errorf("github.Add: already added: %q", project)
162+
return nil
163163
}
164164
c.db.Set(key, storage.JSON(&projectSync{Name: project}))
165165
return nil

0 commit comments

Comments
 (0)