linter proposal: detect using of a context known to be expired in a deferred cleanup action

[starius]

Welcome

• Yes, I've searched similar issues on GitHub and didn't find any.
• I agree to follow this project's Code of Conduct

How did you install golangci-lint?

I don't know

Your feature request related to a problem? Please describe

I have the following code:

func foo(ctx context.Context) error {
  id, err := acquireResource(ctx)
  if err != nil {
    return err
  }

  defer func() {
    err := releaseResource(ctx, id)
    if err != nil {
      printWarning(err)
    }
  }()

  ...
  select {
  case <-ctx.Done():
    return ctx.Err()

  ...
  }

In this function at least some return paths happen because the ctx expires. In this case function releaseResource would fail to release a resource, because ctx expired.

Describe the solution you'd like

It makes sense to change the code as follows:

    err := releaseResource(context.WithoutCancel(ctx), id)

so an expired context wouldn't prevent the cleanup.

Describe alternatives you've considered

I don't know any alternatives.

Additional context

No response

Supporter

• I am a sponsor through GitHub or OpenCollective

[boring-cyborg[bot]]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.