Improve goanalysis issue-cache reuse for well-typed packages

[YuheiTakagawa]

I would like to contribute a small goanalysis cache improvement.

Currently, when a lint run contains typechecking / ill-typed package errors, goanalysis issue-cache saves can be skipped for the run. In large repositories this means packages that were successfully analyzed are not reused by later runs, even though only a subset of packages had errors.

The proposed change is to save issue-cache entries for packages that were successfully analyzed, while continuing to skip packages with typechecking or analysis errors.

The PR would also add --verbose stats for goanalysis issue-cache load/save behavior and package loading, so cache reuse is easier to diagnose.

Planned scope:

• Add verbose goanalysis issue-cache load/save stats.
• Save goanalysis issue-cache entries for well-typed / successfully analyzed packages.
• Keep errored packages excluded from cache saves.
• Narrow issue-cache invalidation only for syntax-only load modes.
• Add package-loading stats for diagnostics.

Out of scope for the first PR:

• Changing goanalysis fact-cache hash modes.
• Relaxing dependency-sensitive fact-cache keys.
• Larger package loading changes.

Local validation so far:

go test ./pkg/goanalysis ./pkg/lint
make build
./golangci-lint run -v

I also attempted make test on Windows. The command failed in the existing cgo integration tests because build constraints excluded all files under test/testdata/cgo*; targeted tests and lint/build checks pass.

[ldez]

Thank you but I will decline the proposal.

This will only create unwanted side effects for a minor edge-case.

[YuheiTakagawa]

Understood, thank you for clarifying. I will not pursue this change further.