Skip to content

Commit ee184c8

Browse files
committed
replace _all_ of the with %q
1 parent 3e326d1 commit ee184c8

File tree

99 files changed

+195
-195
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

99 files changed

+195
-195
lines changed

command-line.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ func TestCLI(t *testing.T) {
214214
want := "Chris"
215215

216216
if got != want {
217-
t.Errorf("didn't record correct winner, got '%s', want '%s'", got, want)
217+
t.Errorf("didn't record correct winner, got %q, want %q", got, want)
218218
}
219219
}
220220
```
@@ -269,7 +269,7 @@ func assertPlayerWin(t *testing.T, store *StubPlayerStore, winner string) {
269269
}
270270

271271
if store.winCalls[0] != winner {
272-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], winner)
272+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], winner)
273273
}
274274
}
275275
```
@@ -480,7 +480,7 @@ func AssertPlayerWin(t *testing.T, store *StubPlayerStore, winner string) {
480480
}
481481

482482
if store.winCalls[0] != winner {
483-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], winner)
483+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], winner)
484484
}
485485
}
486486

command-line/v1/server_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func TestStoreWins(t *testing.T) {
9292
}
9393

9494
if store.winCalls[0] != player {
95-
t.Errorf("did not store the correct winner got '%s' want '%s'", store.winCalls[0], player)
95+
t.Errorf("did not store the correct winner got %q want %q", store.winCalls[0], player)
9696
}
9797
})
9898
}
@@ -135,7 +135,7 @@ func getLeagueFromResponse(t *testing.T, body io.Reader) []Player {
135135
league, err := NewLeague(body)
136136

137137
if err != nil {
138-
t.Fatalf("Unable to parse response from server '%s' into slice of Player, '%v'", body, err)
138+
t.Fatalf("Unable to parse response from server %q into slice of Player, '%v'", body, err)
139139
}
140140

141141
return league
@@ -173,6 +173,6 @@ func newPostWinRequest(name string) *http.Request {
173173
func assertResponseBody(t *testing.T, got, want string) {
174174
t.Helper()
175175
if got != want {
176-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
176+
t.Errorf("response body is wrong, got %q want %q", got, want)
177177
}
178178
}

command-line/v1/tape_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ func TestTape_Write(t *testing.T) {
2020
want := "abc"
2121

2222
if got != want {
23-
t.Errorf("got '%s' want '%s'", got, want)
23+
t.Errorf("got %q want %q", got, want)
2424
}
2525
}

command-line/v2/server_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func TestStoreWins(t *testing.T) {
9292
}
9393

9494
if store.winCalls[0] != player {
95-
t.Errorf("did not store the correct winner got '%s' want '%s'", store.winCalls[0], player)
95+
t.Errorf("did not store the correct winner got %q want %q", store.winCalls[0], player)
9696
}
9797
})
9898
}
@@ -135,7 +135,7 @@ func getLeagueFromResponse(t *testing.T, body io.Reader) []Player {
135135
league, err := NewLeague(body)
136136

137137
if err != nil {
138-
t.Fatalf("Unable to parse response from server '%s' into slice of Player, '%v'", body, err)
138+
t.Fatalf("Unable to parse response from server %q into slice of Player, '%v'", body, err)
139139
}
140140

141141
return league
@@ -173,6 +173,6 @@ func newPostWinRequest(name string) *http.Request {
173173
func assertResponseBody(t *testing.T, got, want string) {
174174
t.Helper()
175175
if got != want {
176-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
176+
t.Errorf("response body is wrong, got %q want %q", got, want)
177177
}
178178
}

command-line/v2/tape_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ func TestTape_Write(t *testing.T) {
2020
want := "abc"
2121

2222
if got != want {
23-
t.Errorf("got '%s' want '%s'", got, want)
23+
t.Errorf("got %q want %q", got, want)
2424
}
2525
}

command-line/v3/server_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func getLeagueFromResponse(t *testing.T, body io.Reader) []Player {
109109
league, err := NewLeague(body)
110110

111111
if err != nil {
112-
t.Fatalf("Unable to parse response from server '%s' into slice of Player, '%v'", body, err)
112+
t.Fatalf("Unable to parse response from server %q into slice of Player, '%v'", body, err)
113113
}
114114

115115
return league
@@ -147,6 +147,6 @@ func newPostWinRequest(name string) *http.Request {
147147
func assertResponseBody(t *testing.T, got, want string) {
148148
t.Helper()
149149
if got != want {
150-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
150+
t.Errorf("response body is wrong, got %q want %q", got, want)
151151
}
152152
}

command-line/v3/tape_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ func TestTape_Write(t *testing.T) {
2020
want := "abc"
2121

2222
if got != want {
23-
t.Errorf("got '%s' want '%s'", got, want)
23+
t.Errorf("got %q want %q", got, want)
2424
}
2525
}

command-line/v3/testing.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ func AssertPlayerWin(t *testing.T, store *StubPlayerStore, winner string) {
3434
}
3535

3636
if store.WinCalls[0] != winner {
37-
t.Errorf("did not store the correct winner got '%s' want '%s'", store.WinCalls[0], winner)
37+
t.Errorf("did not store the correct winner got %q want %q", store.WinCalls[0], winner)
3838
}
3939
}

dependency-injection.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ func TestGreet(t *testing.T) {
7575
want := "Hello, Chris"
7676

7777
if got != want {
78-
t.Errorf("got '%s' want '%s'", got, want)
78+
t.Errorf("got %q want %q", got, want)
7979
}
8080
}
8181
```

di/v1/di_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ func TestGreet(t *testing.T) {
1313
want := "Hello, Chris"
1414

1515
if got != want {
16-
t.Errorf("got '%s' want '%s'", got, want)
16+
t.Errorf("got %q want %q", got, want)
1717
}
1818
}

di/v2/di_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@ func TestGreet(t *testing.T) {
1313
want := "Hello, Chris"
1414

1515
if got != want {
16-
t.Errorf("got '%s' want '%s'", got, want)
16+
t.Errorf("got %q want %q", got, want)
1717
}
1818
}

for/v1/repeat_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ func TestRepeat(t *testing.T) {
77
expected := "aaaaa"
88

99
if repeated != expected {
10-
t.Errorf("expected '%s' but got '%s'", expected, repeated)
10+
t.Errorf("expected %q but got %q", expected, repeated)
1111
}
1212
}

for/v2/repeat_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ func TestRepeat(t *testing.T) {
77
expected := "aaaaa"
88

99
if repeated != expected {
10-
t.Errorf("expected '%s' but got '%s'", expected, repeated)
10+
t.Errorf("expected %q but got %q", expected, repeated)
1111
}
1212
}

for/vx/repeat_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ func TestRepeat(t *testing.T) {
77
expected := "aaaaa"
88

99
if repeated != expected {
10-
t.Errorf("expected '%s' but got '%s'", expected, repeated)
10+
t.Errorf("expected %q but got %q", expected, repeated)
1111
}
1212
}
1313

http-server.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func TestGETPlayers(t *testing.T) {
7777
want := "20"
7878

7979
if got != want {
80-
t.Errorf("got '%s', want '%s'", got, want)
80+
t.Errorf("got %q, want %q", got, want)
8181
}
8282
})
8383
}
@@ -204,7 +204,7 @@ t.Run("returns Floyd's score", func(t *testing.T) {
204204
want := "10"
205205

206206
if got != want {
207-
t.Errorf("got '%s', want '%s'", got, want)
207+
t.Errorf("got %q, want %q", got, want)
208208
}
209209
})
210210
```
@@ -306,7 +306,7 @@ func newGetScoreRequest(name string) *http.Request {
306306
func assertResponseBody(t *testing.T, got, want string) {
307307
t.Helper()
308308
if got != want {
309-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
309+
t.Errorf("response body is wrong, got %q want %q", got, want)
310310
}
311311
}
312312
```
@@ -605,7 +605,7 @@ func newGetScoreRequest(name string) *http.Request {
605605
func assertResponseBody(t *testing.T, got, want string) {
606606
t.Helper()
607607
if got != want {
608-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
608+
t.Errorf("response body is wrong, got %q want %q", got, want)
609609
}
610610
}
611611
```
@@ -855,7 +855,7 @@ t.Run("it records wins on POST", func(t *testing.T) {
855855
}
856856

857857
if store.winCalls[0] != player {
858-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], player)
858+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], player)
859859
}
860860
})
861861
```

http-server/v1/server_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func TestGETPlayers(t *testing.T) {
1717
want := "20"
1818

1919
if got != want {
20-
t.Errorf("got '%s', want '%s'", got, want)
20+
t.Errorf("got %q, want %q", got, want)
2121
}
2222
})
2323

http-server/v2/server_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,6 @@ func newGetScoreRequest(name string) *http.Request {
7070
func assertResponseBody(t *testing.T, got, want string) {
7171
t.Helper()
7272
if got != want {
73-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
73+
t.Errorf("response body is wrong, got %q want %q", got, want)
7474
}
7575
}

http-server/v3/server_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,6 @@ func newGetScoreRequest(name string) *http.Request {
8686
func assertResponseBody(t *testing.T, got, want string) {
8787
t.Helper()
8888
if got != want {
89-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
89+
t.Errorf("response body is wrong, got %q want %q", got, want)
9090
}
9191
}

http-server/v4/server_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func TestStoreWins(t *testing.T) {
8383
}
8484

8585
if store.winCalls[0] != player {
86-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], player)
86+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], player)
8787
}
8888
})
8989
}
@@ -103,6 +103,6 @@ func newGetScoreRequest(name string) *http.Request {
103103
func assertResponseBody(t *testing.T, got, want string) {
104104
t.Helper()
105105
if got != want {
106-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
106+
t.Errorf("response body is wrong, got %q want %q", got, want)
107107
}
108108
}

http-server/v5/server_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ func TestStoreWins(t *testing.T) {
8383
}
8484

8585
if store.winCalls[0] != player {
86-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], player)
86+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], player)
8787
}
8888
})
8989
}
@@ -108,6 +108,6 @@ func newPostWinRequest(name string) *http.Request {
108108
func assertResponseBody(t *testing.T, got, want string) {
109109
t.Helper()
110110
if got != want {
111-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
111+
t.Errorf("response body is wrong, got %q want %q", got, want)
112112
}
113113
}

io.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -850,7 +850,7 @@ func TestTape_Write(t *testing.T) {
850850
want := "abc"
851851

852852
if got != want {
853-
t.Errorf("got '%s' want '%s'", got, want)
853+
t.Errorf("got %q want %q", got, want)
854854
}
855855
}
856856
```

io/v1/server_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func TestStoreWins(t *testing.T) {
9292
}
9393

9494
if store.winCalls[0] != player {
95-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], player)
95+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], player)
9696
}
9797
})
9898
}
@@ -135,7 +135,7 @@ func getLeagueFromResponse(t *testing.T, body io.Reader) []Player {
135135
league, err := NewLeague(body)
136136

137137
if err != nil {
138-
t.Fatalf("Unable to parse response from server '%s' into slice of Player, '%v'", body, err)
138+
t.Fatalf("Unable to parse response from server %q into slice of Player, '%v'", body, err)
139139
}
140140

141141
return league
@@ -173,6 +173,6 @@ func newPostWinRequest(name string) *http.Request {
173173
func assertResponseBody(t *testing.T, got, want string) {
174174
t.Helper()
175175
if got != want {
176-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
176+
t.Errorf("response body is wrong, got %q want %q", got, want)
177177
}
178178
}

io/v2/server_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func TestStoreWins(t *testing.T) {
9292
}
9393

9494
if store.winCalls[0] != player {
95-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], player)
95+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], player)
9696
}
9797
})
9898
}
@@ -135,7 +135,7 @@ func getLeagueFromResponse(t *testing.T, body io.Reader) []Player {
135135
league, err := NewLeague(body)
136136

137137
if err != nil {
138-
t.Fatalf("Unable to parse response from server '%s' into slice of Player, '%v'", body, err)
138+
t.Fatalf("Unable to parse response from server %q into slice of Player, '%v'", body, err)
139139
}
140140

141141
return league
@@ -173,6 +173,6 @@ func newPostWinRequest(name string) *http.Request {
173173
func assertResponseBody(t *testing.T, got, want string) {
174174
t.Helper()
175175
if got != want {
176-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
176+
t.Errorf("response body is wrong, got %q want %q", got, want)
177177
}
178178
}

io/v3/server_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func TestStoreWins(t *testing.T) {
9292
}
9393

9494
if store.winCalls[0] != player {
95-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], player)
95+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], player)
9696
}
9797
})
9898
}
@@ -135,7 +135,7 @@ func getLeagueFromResponse(t *testing.T, body io.Reader) []Player {
135135
league, err := NewLeague(body)
136136

137137
if err != nil {
138-
t.Fatalf("Unable to parse response from server '%s' into slice of Player, '%v'", body, err)
138+
t.Fatalf("Unable to parse response from server %q into slice of Player, '%v'", body, err)
139139
}
140140

141141
return league
@@ -173,6 +173,6 @@ func newPostWinRequest(name string) *http.Request {
173173
func assertResponseBody(t *testing.T, got, want string) {
174174
t.Helper()
175175
if got != want {
176-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
176+
t.Errorf("response body is wrong, got %q want %q", got, want)
177177
}
178178
}

io/v4/server_test.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func TestStoreWins(t *testing.T) {
9292
}
9393

9494
if store.winCalls[0] != player {
95-
t.Errorf("did not store correct winner got '%s' want '%s'", store.winCalls[0], player)
95+
t.Errorf("did not store correct winner got %q want %q", store.winCalls[0], player)
9696
}
9797
})
9898
}
@@ -135,7 +135,7 @@ func getLeagueFromResponse(t *testing.T, body io.Reader) []Player {
135135
league, err := NewLeague(body)
136136

137137
if err != nil {
138-
t.Fatalf("Unable to parse response from server '%s' into slice of Player, '%v'", body, err)
138+
t.Fatalf("Unable to parse response from server %q into slice of Player, '%v'", body, err)
139139
}
140140

141141
return league
@@ -173,6 +173,6 @@ func newPostWinRequest(name string) *http.Request {
173173
func assertResponseBody(t *testing.T, got, want string) {
174174
t.Helper()
175175
if got != want {
176-
t.Errorf("response body is wrong, got '%s' want '%s'", got, want)
176+
t.Errorf("response body is wrong, got %q want %q", got, want)
177177
}
178178
}

0 commit comments

Comments
 (0)