Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript support #13

Closed
SaeedZhiany opened this issue Dec 17, 2019 · 3 comments
Closed

Typescript support #13

SaeedZhiany opened this issue Dec 17, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@SaeedZhiany
Copy link

It would be great to add type definition file to your library, then it can be more useful in projects that developed using typescript.

@gomjellie
Copy link
Owner

I don't know anything about typescript, so It would be great if you help me to add type definitions 😃. can u give me a hand plz?

@SaeedZhiany
Copy link
Author

Oh, So you need to read some documentation at the start. I recommend you start with http://www.typescriptlang.org/ the official website of typescript. also, you can inspire from many famous react-native libraries that have type definition files. for example

https://github.com/proyecto26/react-native-inappbrowser
https://github.com/react-native-community/react-native-svg

Also, there are more tutorials that show how you can add support for typescript. after reading some initial articles about typescript you'll simply be able to work with it. (even maybe you decide to rewrite your library with typescript)

Unfortunately, I'm busy these days and I can't work in on it directly, sorry about that.

@gomjellie
Copy link
Owner

I'll consider it :)

@gomjellie gomjellie pinned this issue Dec 17, 2019
@gomjellie gomjellie added the enhancement New feature or request label Dec 17, 2019
@rubycho rubycho added this to the v.1.0.5 milestone Dec 4, 2020
@rubycho rubycho mentioned this issue Dec 4, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants