feat: Apply filters follow up #6034

ondrejvelisek · 2025-03-10T16:00:43Z

fix(sdk-ui-dashboard): make working state update in attribute filter

feat(sdk-ui-dashboard): show working selection in filter button

when apply all at once config is used
fix inverted logic for attribute working selection

fix(sdk-ui-dashboard): make working state update date filter

feat(sdk-ui-dashboard): remove apply from attribute filter

and rename cancel to close

feat(sdk-ui-dashboard): remove apply from date filter

and rename cancel to close

feat(sdk-ui-dashboard): remove attribute filter status bar

feat(sdk-ui-dashboard): add unapplied filters banner

hide apply button instead of diable it when no changes
fix reversed selector

feat(sdk-ui-dashboard): make reset btn reset working filters too

add reset all working filters command
fix depcruiser errors

fix(sdk-ui): missing localization entry for close button

feat(sdk-ui-dashboard): support saved views in apply all at once

fix(sdk-ui-dashboard): responsivness in apply all at once mode

feat(sdk-ui-dashboard): make crossfiltering work properly

trigger filter context change event for workign state changes too
handle filter invalid state properly

feat(sdk-ui-dashboard): hide new apply all filters behind FF

enableDashboardFiltersApplyModes

Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.

Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

--backstop The command to run screen tests.
--integrated The command to run integrated tests against the live backend.
--isolated The command to run isolated tests against recordings.
--record The command to create new recordings for isolated tests.
--filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

JIRA: GDP-2938 risk: low

- when apply all at once config is used - fix inverted logic for attribute working selection JIRA: GDP-2938 risk: low

JIRA: GDP-2938 risk: low

- and rename cancel to close JIRA: GDP-2938 risk: low

JIRA: GDP-2938 risk: low

- hide apply button instead of diable it when no changes - fix reversed selector JIRA: GDP-2938 risk: low

- add reset all working filters command - fix depcruiser errors JIRA: GDP-2938 risk: low

JIRA: GDP-2938 risk: low

- trigger filter context change event for workign state changes too - handle filter invalid state properly JIRA: GDP-2938 risk: low

- enableDashboardFiltersApplyModes JIRA: GDP-2938 risk: low

JIRA: GDP-2938 risk: low

kandl · 2025-03-11T07:25:03Z

extended-test --backstop

github-actions · 2025-03-11T07:25:42Z

"extended-test --backstop" started. Check the progress here.

kandl · 2025-03-11T07:28:36Z

common/changes/@gooddata/sdk-ui-all/ovel-apply-filters-phase-4_2025-03-10-17-00.json

+    "changes": [
+        {
+            "packageName": "@gooddata/sdk-ui-all",
+            "comment": "Support of new filter mode Apply all at once",


It should be clear that it's a Dashboard component feature

kandl · 2025-03-11T07:32:24Z

...dashboard/src/presentation/dragAndDrop/draggableAttributeFilter/DraggableAttributeFilter.tsx

@@ -84,6 +96,7 @@ export function DraggableAttributeFilter({
            >
                <FilterComponent
                    filter={filterToUse}
+                    workingFilter={enableDashboardFiltersApplyModes ? workingFilterToUse : undefined}


Is this prop really required?

After discussion on Slack we decided to deprecate this prop for now and remove it in the future phase 5 refactoring.

We will pass workingFilterToUse into regular filter prop instead.

Which means the inner filter state will think those incoming working filters are applied. But we do not need to distinguish between applied and working state for now. And we prefer to keep filters component API simple.

Similar change should be done for DateFilter.

github-actions · 2025-03-11T07:57:46Z

❌ "extended-test --backstop" finished with result failure. Check the results here.

- we will remove them and use regular variants for sync working state instead - improve changelog message JIRA: GDP-2938 risk: low

- not sure why TypeScript check is not catching this JIRA: GDP-2938 risk: low

ondrejvelisek · 2025-03-11T09:27:24Z

extended-test --backstop

github-actions · 2025-03-11T09:28:05Z

"extended-test --backstop" started. Check the progress here.

github-actions · 2025-03-11T09:40:35Z

❌ "extended-test --backstop" finished with result failure. Check the results here.

kandl · 2025-03-11T09:52:13Z

extended-test --integrated

github-actions · 2025-03-11T09:52:57Z

"extended-test --integrated" started. Check the progress here.

github-actions · 2025-03-11T09:59:05Z

✅ "extended-test --integrated" finished with result success. Check the results here.

kandl

LGTM

ondrejvelisek added 12 commits March 7, 2025 08:17

fix(sdk-ui-dashboard): make working state update in attribute filter

577f440

JIRA: GDP-2938 risk: low

feat(sdk-ui-dashboard): show working selection in filter button

f7dd721

- when apply all at once config is used - fix inverted logic for attribute working selection JIRA: GDP-2938 risk: low

fix(sdk-ui-dashboard): make working state update date filter

294d9e4

JIRA: GDP-2938 risk: low

feat(sdk-ui-dashboard): remove apply from attribute filter

b518660

- and rename cancel to close JIRA: GDP-2938 risk: low

feat(sdk-ui-dashboard): remove apply from date filter

ace7808

- and rename cancel to close JIRA: GDP-2938 risk: low

feat(sdk-ui-dashboard): remove attribute filter status bar

88c1575

JIRA: GDP-2938 risk: low

feat(sdk-ui-dashboard): add unapplied filters banner

d348fb8

- hide apply button instead of diable it when no changes - fix reversed selector JIRA: GDP-2938 risk: low

feat(sdk-ui-dashboard): make reset btn reset working filters too

a7f1b5c

- add reset all working filters command - fix depcruiser errors JIRA: GDP-2938 risk: low

fix(sdk-ui): missing localization entry for close button

34a4cfb

JIRA: GDP-2938 risk: low

feat(sdk-ui-dashboard): support saved views in apply all at once

1ca06fc

JIRA: GDP-2938 risk: low

fix(sdk-ui-dashboard): responsivness in apply all at once mode

adbe5c5

JIRA: GDP-2938 risk: low

feat(sdk-ui-dashboard): make crossfiltering work properly

542e460

- trigger filter context change event for workign state changes too - handle filter invalid state properly JIRA: GDP-2938 risk: low

ondrejvelisek requested review from NestorEncinas and kandl as code owners March 10, 2025 16:00

ondrejvelisek added 2 commits March 10, 2025 17:58

feat(sdk-ui-dashboard): hide new apply all filters behind FF

dea9d0c

- enableDashboardFiltersApplyModes JIRA: GDP-2938 risk: low

chore(sdk-ui-all): add changelog

62b40be

JIRA: GDP-2938 risk: low

kandl reviewed Mar 11, 2025

View reviewed changes

chore(sdk-ui-filters): deprecate working filters props

87a3d19

- we will remove them and use regular variants for sync working state instead - improve changelog message JIRA: GDP-2938 risk: low

ondrejvelisek force-pushed the ovel/apply-filters-phase-4 branch from e6fbd76 to 87a3d19 Compare March 11, 2025 09:00

fix(sdk-ui-filters): undefined workingFilter prop

f53489b

- not sure why TypeScript check is not catching this JIRA: GDP-2938 risk: low

kandl approved these changes Mar 11, 2025

View reviewed changes

kandl enabled auto-merge March 11, 2025 10:03

kandl merged commit d552e94 into master Mar 11, 2025
15 checks passed

kandl deleted the ovel/apply-filters-phase-4 branch March 11, 2025 10:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Apply filters follow up #6034

feat: Apply filters follow up #6034

ondrejvelisek commented Mar 10, 2025 •

edited

Loading

kandl commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

kandl Mar 11, 2025

kandl Mar 11, 2025

ondrejvelisek Mar 11, 2025

ondrejvelisek Mar 11, 2025

github-actions bot commented Mar 11, 2025

ondrejvelisek commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

kandl commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

kandl left a comment

feat: Apply filters follow up #6034

feat: Apply filters follow up #6034

Conversation

ondrejvelisek commented Mar 10, 2025 • edited Loading

Run extended test by pull request comment

Explanation

Examples

kandl commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

kandl Mar 11, 2025

Choose a reason for hiding this comment

kandl Mar 11, 2025

Choose a reason for hiding this comment

ondrejvelisek Mar 11, 2025

Choose a reason for hiding this comment

ondrejvelisek Mar 11, 2025

Choose a reason for hiding this comment

github-actions bot commented Mar 11, 2025

ondrejvelisek commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

kandl commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

github-actions bot commented Mar 11, 2025

kandl left a comment

Choose a reason for hiding this comment

ondrejvelisek commented Mar 10, 2025 •

edited

Loading