Skip to content

Pushd and popd commands still haven't been removed from download scripts on the main branch. #557

@dgzct11

Description

@dgzct11

Hello,

When I tried to run download_all_data.sh, I kept running into a gzip error where it couldn't find the file. The path and filename seemed right, but when digging through the issues and scripts, I found that download_mgnify.sh, download_small_bfd.sh, download_uniprot.sh, and download_uniref90.sh on the main branch still had the extra pushd and popd pointed out in #305 and #459.

pushd "${ROOT_DIR}"
gunzip "${ROOT_DIR}/${BASENAME}"
popd

where ROOT_DIR="${DOWNLOAD_DIR}/(name of database being downloaded)"

To my understanding, this code is entering the root dir, and then unzipping the file with root_dir in the path again. If the user-specified DOWNLOAD_DIR isn't the full path, then this will cause an error. If it is the full path, then pushd and popd are useless.

What would be the process for getting this fixed?

Thank you in advance!

Metadata

Metadata

Assignees

No one assigned

    Labels

    setupIssue setting up AlphaFold

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions