Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Needed in Datasets #379

Open
bebark opened this issue Jul 21, 2023 · 1 comment
Open

Updates Needed in Datasets #379

bebark opened this issue Jul 21, 2023 · 1 comment
Assignees

Comments

@bebark
Copy link

bebark commented Jul 21, 2023

The grad_updates_per_step hyperparameter for SAC changed at some point in the last year or two from being a decimal value to being an integer. I believe the old values are just the inversions of the new (e.g. 8 is 0.125). Is that correct? Either way the brax/datasets readme and data are out of sync with the rest of the repo since they follow the old decimal convention.

@LabChameleon
Copy link

LabChameleon commented Dec 18, 2023

I had a look at the old training code and I don't think the number of grad_updates_per_step is the inverted decimal number. Considering

num_updates = int(num_envs * grad_updates_per_step)
the number of steps is num_envs * grad_updates_per_step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants