Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make setDescription public on RoutineInfo.Builder #3170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hamnis
Copy link

@hamnis hamnis commented Feb 26, 2024

Previously it was not possible to use RoutineInfo.Builder directly to set the description.

It was possible via the Routine.Builder, but this allows users to not care about this fact.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3169

@hamnis hamnis requested a review from a team as a code owner February 26, 2024 08:02
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Feb 26, 2024
Previously it was not possible to use RoutineInfo.Builder directly
to set the description.

It was possible via the Routine.Builder, but this allows users to not
care about this fact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to call setDescription on RoutineInfo.Builder
1 participant