This repository was archived by the owner on Aug 25, 2018. It is now read-only.
forked from yeoman/generator-angular
-
Notifications
You must be signed in to change notification settings - Fork 52
Bootstrap 3.3.5 Bower Overrides #57
Comments
Should check and see if this was fixed in generator-angular first. Probably about time to merge the upstream again. |
Looks like it was fixed in generator-angular. yeoman@209100d |
Should be issue be fixed in the current version? |
What's your bower.json look like? Here's mine after a vanilla install and additional override that works OK. {
"name": "aftest",
"version": "0.0.0",
"dependencies": {
"angular": "^1.3.0",
"firebase": "2.2.2",
"angularfire": "1.0.0",
"bootstrap": "^3.2.0",
"angular-animate": "^1.3.0",
"angular-cookies": "^1.3.0",
"angular-resource": "^1.3.0",
"angular-route": "^1.3.0",
"angular-sanitize": "^1.3.0",
"angular-touch": "^1.3.0"
},
"devDependencies": {
"mockfirebase": "0.11.0",
"angular-mocks": "^1.3.0"
},
"appPath": "app",
"moduleName": "aftestApp",
"overrides": {
"bootstrap": {
"main": [
"dist/js/bootstrap.js",
"dist/css/bootstrap.css",
"less/bootstrap.less"
]
}
}
} |
My mistake, I didn't write the overrides manually, I thought it would be done during install. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On generating a new project, the version of bootstrap (if required) is currently defaulting to 3.3.5 which breaks wiredep. The fix (as in the Bootstrap release notes: http://blog.getbootstrap.com/2015/06/15/bootstrap-3-3-5-released/) is to add an override block to bower.json. I'm happy to submit a pull request with the change but wanted to at least run it here first in case it's already there and I'm missing something.
The text was updated successfully, but these errors were encountered: