Adding a check in the less than method for the VariantCall class to ensure that in cases where there is a mix of arrays and scalar values that the comparison still works.#701
Open
adaykin wants to merge 1 commit into
Conversation
…nsure that in cases where there is a mix of arrays and scalar values that the comparison still works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a check in the less than method for the VariantCall class to ensure that in cases where there is a mix of arrays and scalar values that the comparison still works.
When running bq_to_vcf the lt method in VariantCall was attempting to compare a list to a single value (-1) that is getting set by using the MISSING_GENOTYPE_VALUE (set to -1) in the densify_variants._densify_variants method. This was causing an exception to occur.
Test:
Added a unit test and ran a test manually on a dataset that was receiving the error mentioned above to make sure the bq_to_vcf could successfully generate a VCF file.