Skip to content

[Bug]: [iOS] All headers marked as private breaking compatibility with react-native-driver-sdk #503

@ringo-redbit

Description

@ringo-redbit

Is there an existing issue for this?

  • I have searched the existing issues

Description of the bug

Starting in version 0.10.1, all header files are marked as private in the podspec, which breaks compatibility with react-native-driver-sdk that needs to import NavModule.h and INavigationCallback.h.

The current podspec configuration marks all headers as private: s.private_header_files = "ios/**/*.h"

Solution:

s.source_files = "ios/**/*.{h,m,mm,cpp}"
s.public_header_files = [
  "ios/react-native-navigation-sdk/NavModule.h",
  "ios/react-native-navigation-sdk/INavigationCallback.h"
]

Environment

  • react-native-navigation-sdk: 0.11.0
  • react-native-driver-sdk: 0.3.2
  • CocoaPods: 1.16.2
  • iOS: 16.0+

React Native version

0.81.4

React version

19.1.0

Package version

0.11.0

Native SDK versions

  • I haven't changed the version of the native SDKs

React Native Doctor Output

Common
✓ Node.js - Required to execute JavaScript code
✓ npm - Required to install NPM dependencies
✓ Watchman - Used for watching changes in the filesystem when in development mode
● Metro - Metro Bundler is not running

Android
✖ Adb - No devices and/or emulators connected. Please create emulator with Android Studio or connect Android device.
✓ JDK - Required to compile Java code
✓ Android Studio - Required for building and installing your app on Android
✓ ANDROID_HOME - Environment variable that points to your Android SDK installation
✓ Gradlew - Build tool required for Android builds
✓ Android SDK - Required for building and installing your app on Android

iOS
✓ Xcode - Required for building and installing your app on iOS
✓ Ruby - Required for installing iOS dependencies
✓ CocoaPods - Required for installing iOS dependencies
✓ .xcode.env - File to customize Xcode environment

Errors: 1
Warnings: 1

Steps to reproduce

  1. Install both the latest navigation and driver SDKs and try to build

Expected vs Actual Behavior

Expected: It should build

Actual: @googlemaps/react-native-driver-sdk/ios/RCTRideSharingModule.m:19:9: fatal error: 'react-native-navigation-sdk/NavModule.h' file not found

Code Sample

// Example code here

Additional Context

No response

Metadata

Metadata

Assignees

Labels

priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions