Skip to content
This repository was archived by the owner on Oct 3, 2024. It is now read-only.

Commit 32ab68f

Browse files
SUPERCILEXsamtstern
authored andcommitted
Use framework dialog where applicable (#153)
1 parent 556b2ce commit 32ab68f

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed

easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogConfig.java

+10-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ Bundle toBundle() {
5454
return bundle;
5555
}
5656

57-
AlertDialog createDialog(Context context, Dialog.OnClickListener listener) {
57+
AlertDialog createSupportDialog(Context context, Dialog.OnClickListener listener) {
5858
return new AlertDialog.Builder(context)
5959
.setCancelable(false)
6060
.setPositiveButton(positiveButton, listener)
@@ -63,4 +63,13 @@ AlertDialog createDialog(Context context, Dialog.OnClickListener listener) {
6363
.create();
6464
}
6565

66+
android.app.AlertDialog createFrameworkDialog(Context context, Dialog.OnClickListener listener) {
67+
return new android.app.AlertDialog.Builder(context)
68+
.setCancelable(false)
69+
.setPositiveButton(positiveButton, listener)
70+
.setNegativeButton(negativeButton, listener)
71+
.setMessage(rationaleMsg)
72+
.create();
73+
}
74+
6675
}

easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogFragment.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
7373
new RationaleDialogClickListener(this, config, mPermissionCallbacks);
7474

7575
// Create an AlertDialog
76-
return config.createDialog(getActivity(), clickListener);
76+
return config.createFrameworkDialog(getActivity(), clickListener);
7777
}
7878

7979
}

easypermissions/src/main/java/pub/devrel/easypermissions/RationaleDialogFragmentCompat.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,6 @@ public Dialog onCreateDialog(Bundle savedInstanceState) {
6565
new RationaleDialogClickListener(this, config, mPermissionCallbacks);
6666

6767
// Create an AlertDialog
68-
return config.createDialog(getContext(), clickListener);
68+
return config.createSupportDialog(getContext(), clickListener);
6969
}
7070
}

0 commit comments

Comments
 (0)