Repository navigation
Commit 7a84dcf
authored
PROC-1513: accept Conventional Commit titles with Linear ID in scope (#6)
## Summary
Widen the PR title check so titles like `feat(ENG-123): add feature` are
accepted in addition to the existing `ENG-123: ...` and `NO-ISSUE:`
formats.
## Why
Adopting [release-please](https://github.com/googleapis/release-please)
in `cloud_optimized_dicom` (see [PR
#97](gradienthealth/cloud_optimized_dicom#97))
requires PR titles to start with a Conventional Commit type prefix
(`feat:`, `fix:`, `chore:`, etc.) so the bot can decide the next
version. The existing org-level check requires the Linear ID at the very
start, which conflicts. Putting the Linear ID inside the
conventional-commit scope (`feat(ENG-123): ...`) satisfies both worlds,
but the current regex doesn't recognize it.
## Change
Two new branches added to the existing if/elif chain:
- Conventional Commit with Linear ID in scope: `feat(ENG-123): add
feature`
- Conventional Commit with `NO-ISSUE` opt-out: `chore: NO-ISSUE refactor
internals`
Existing formats continue to pass — pure superset, zero behavior change
for repos not adopting Conventional Commits.
## Test plan
- [ ] Title `ENG-123: existing format` → passes (unchanged)
- [ ] Title `feat(ENG-123): new format` → passes (new)
- [ ] Title `NO-ISSUE: opt-out` → passes (unchanged)
- [ ] Title `chore: NO-ISSUE thing` → passes (new)
- [ ] Title `random title with no marker` → fails1 parent b106dda commit 7a84dcf
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
| 28 | + | |
| 29 | + | |
26 | 30 | | |
27 | | - | |
| 31 | + | |
28 | 32 | | |
29 | 33 | | |
0 commit comments