Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All internal components are renamed to Develocity #678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erichaagdev
Copy link
Member

This PR updates all internal references from Gradle Enterprise to Develocity.

Much of this is just a simple rename of ge and gradle enterprise to develocity, but there were a few occurrences where this wasn't the case. I have outlined any noteworthy and exceptional cases below:

  • The bundled Maven extension was renamed from configure-gradle-enterprise-maven-extension to configure-develocity-maven-extension (it still configures both)
  • All system properties passed to configure-develocity-maven-extension had their prefixes updated from com.gradle.enterprise.build-validation to develocity.build-validation
    • For Gradle, this has already been done, setting aside the fact that Gradle now configures the init script using environment variables
    • I made certain to not rename the system properties that are configuring the "Gradle Enterprise" Maven extension directly, such as gradle.enterprise.url and gradle.enterprise.allowUntrustedServer as these must remain for as long as we support using the GE Maven extension with the scripts
  • All links pointing to documentation in Gradle.md or Maven.md has been updated from https://github.com/gradle/gradle-enterprise-build-validation-scripts/blob to the special short form redirect https://gradle.com/bvs

What remains are things that cannot yet be updated. This primarily includes all references to the repository, Gradle Enterprise distributions, bundled GE extension.

@erichaagdev erichaagdev self-assigned this Nov 11, 2024
Copy link
Member

@ribafish ribafish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@jprinet jprinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just a question about a GE artifact

@@ -87,7 +87,7 @@ dependencies {
develocityInjection("com.gradle:develocity-injection:1.0")
develocityComponents("com.gradle:build-scan-summary:$buildScanSummaryVersion")
develocityMavenComponents("com.gradle:gradle-enterprise-maven-extension:1.18.4")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this gradle-enterprise artifact expected there?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, yes. This is what gets injected when you use the -e option. Using 1.18.4 gives us compatibility back to Develocity 2023.2. The first "Develocity" extension version is 1.21 which supports only Develocity 2024.1 and greater.

We aren't ready to make that jump yet. I anticipate doing that some time next year which will allow us to get rid of the GE artifacts completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When linking to documentation the short link is not always used
3 participants