Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing contributing section in README #649

Open
gabrielfeo opened this issue Aug 8, 2024 · 3 comments
Open

Missing contributing section in README #649

gabrielfeo opened this issue Aug 8, 2024 · 3 comments

Comments

@gabrielfeo
Copy link

These scripts are very useful. It's not clear how one can contribute, however. Are the bash scripts manually maintained or are they generated from some other source?

@erichaagdev
Copy link
Member

Hi, @gabrielfeo. The Bash scripts are mostly maintained manually. There is some code generated by Argbash, but it's done as part of the build and not committed to the repository.

You can contribute by opening a PR, but it's best to create an issue so any changes can be discussed first. There isn't a guarantee we will integrate the changes either. Changes to the scripts are done very diligently.

Did you have something specific in mind you wanted to contribute, or that you're having trouble with?

@gabrielfeo
Copy link
Author

Hi, @erichaagdev. Thank you for the prompt reply. I thought about proposing improvements to error messages or logging, such as "Encountered an unexpected response while fetching build scan" (but I understand that comes from a jar, not the scripts). Or a fix for #587 (which might be why I got that error in the first place, as I'm on 3.17).

On a side note, switching to another language and adding test coverage would make it much friendlier to contributors, if you're willing to consider that.

@erichaagdev
Copy link
Member

Hi, @gabrielfeo. #587 should be fixed in the latest development release. You can try it out now to confirm. https://github.com/gradle/gradle-enterprise-build-validation-scripts/releases/tag/development-latest

We aren't looking to migrate to another language right now. I do appreciate your enthusiasm about wanting to make contributions, but it would be difficult to do so because part of the scripts is closed source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants