fix(tempo-distributed): order of the registry and pullSecrets to be i… #4026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienDelavande
requested review from
a team,
BitProcessor,
QuentinBisson,
Sheikh-Abubaker,
faustodavid and
swartz-k
as code owners
|
|
…njected Signed-off-by: Julien Delavande <[email protected]>
JulienDelavande
force-pushed
the
main
branch
from
4f91e60 to
58822fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…njected
Description
Problem
The coalesce function in _helpers.tpl had an incorrect priority order for registry and pullSecrets values. The global values were taking precedence over more specific tempo and component values, preventing proper overrides.
Solution
Changed the priority order in the helper functions to follow a logical hierarchy from most specific to least specific:
Changes
tempo.imagePullSecrets: Updated $imagePullSecrets coalesce order from .global.pullSecrets → .component.pullSecrets → - .tempo.pullSecrets to .component.pullSecrets → .tempo.pullSecrets → .global.pullSecrets
Impact
This fix allows users to properly override global registry and pullSecrets settings at the tempo or component level, which is the expected behavior for Helm chart value inheritance.