Helm chart has inconsistent names for components

[evilhamsterman]

Describe the bug
Most components in the Helm chart use the fullname which comes from either the releasename or the fullnameOverride value. They all have a _helpers.tpl with lines like below from the gateway component

{{- define "loki.gatewayFullname" -}}
{{ include "loki.fullname" . }}-gateway
{{- end }}

however the following components

• loki-canary
• read
• write
• backend
• memberlist

all have the following type helper

{{- define "loki.readFullname" -}}
{{ include "loki.name" . }}-read
{{- end }}

which is just the value loki or enterprise-logs or the nameOverride. This leads to inconsistent names, some services and pods are named release-name-loki- some are just loki-. This could also lead to conflicts if you are deploying multiple loki instances

To Reproduce
Steps to reproduce the behavior:
Deploy Loki with the helm chart

Expected behavior
All resources use a consistent naming scheme to allow for easy identification and conflict prevention

Environment:

• Infrastructure: Kubernetes
• Deployment tool: helm

Screenshots, Promtail config, or terminal output
Example

❯ k get pods -l "app.kubernetes.io/instance=it-loki"
NAME                               READY   STATUS    RESTARTS   AGE
it-loki-chunks-cache-0             2/2     Running   0          16m
it-loki-gateway-6f9bf8fdb9-mbm2z   1/1     Running   0          16m
it-loki-gateway-6f9bf8fdb9-tbwhg   1/1     Running   0          16m
it-loki-results-cache-0            2/2     Running   0          16m
loki-backend-0                     2/2     Running   0          16m
loki-backend-1                     2/2     Running   0          16m
loki-read-7b8fb774bc-np2gh         1/1     Running   0          16m
loki-read-7b8fb774bc-zxw5r         1/1     Running   0          16m
loki-write-0                       1/1     Running   0          16m
loki-write-1                       1/1     Running   0          16m
loki-write-2                       1/1     Running   0          16m

❯ k get svc -l "app.kubernetes.io/instance=it-loki"
NAME                                TYPE        CLUSTER-IP      EXTERNAL-IP   PORT(S)              AGE
it-loki-chunks-cache                ClusterIP   None            <none>        11211/TCP,9150/TCP   16m
it-loki-gateway                     ClusterIP   10.102.39.254   <none>        80/TCP               16m
it-loki-query-scheduler-discovery   ClusterIP   None            <none>        3100/TCP,9095/TCP    16m
it-loki-results-cache               ClusterIP   None            <none>        11211/TCP,9150/TCP   16m
loki-backend                        ClusterIP   10.102.43.68    <none>        3100/TCP,9095/TCP    16m
loki-backend-headless               ClusterIP   None            <none>        3100/TCP,9095/TCP    16m
loki-memberlist                     ClusterIP   None            <none>        7946/TCP             16m
loki-read                           ClusterIP   10.102.35.9     <none>        3100/TCP,9095/TCP    16m
loki-read-headless                  ClusterIP   None            <none>        3100/TCP,9095/TCP    16m
loki-write                          ClusterIP   10.102.43.17    <none>        3100/TCP,9095/TCP    16m
loki-write-headless                 ClusterIP   None            <none>        3100/TCP,9095/TCP    16m