fix(goldfish): add tolerances to mismatches in the query-tee #20004
+201
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jnewbigin
force-pushed
the
jnewbigin/goldfish-floatingpoint
branch
from
7db7154 to
1594935
Compare
jnewbigin
force-pushed
the
jnewbigin/goldfish-floatingpoint
branch
2 times, most recently
from
07f32fd to
336918b
Compare
jnewbigin
force-pushed
the
jnewbigin/goldfish-floatingpoint
branch
from
8b96826 to
6f5b89c
Compare
This change relocates response comparator logic to its own package to prevent cyclic imports and improve code organization. No functional changes.
Some results containing floating point numbers might have different hash values but the same effective value. This can come about because adding floating point numbers is not commutative
jnewbigin
force-pushed
the
jnewbigin/goldfish-floatingpoint
branch
from
6f5b89c to
af34838
Compare
Contributor
ashwanthgoli
left a comment
ashwanthgoli
left a comment
There was a problem hiding this comment.
overall LGTM, left some minor suggestions
The short name is prefered as per the Package names Go blog entry
Comment on lines
+66
to
+71
| if err == nil { | ||
| result.ComparisonStatus = goldfish.ComparisonStatusMatch | ||
| result.DifferenceDetails["tolerance_match"] = true | ||
| return result | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
i think we should not return here as we update performance stats in difference details on line 82.
it would be also nice to capture the error in DifferenceDetails to understand why the comparator failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using
query-tee, it is possible for identical floating point data to be returned as different values from different cells. Floating point addition is not commutative so the result is dependent on the order that data is returned.These differences are recorded in goldfish as a mismatch.
This fix will reuse the threshold compare to treat the values in this special case as the same and report the values as matching (even when they have a different hash value).
In order to reuse the
ResponsesComparatorwithout cyclic dependencies, it has been factored into it's own packageWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR