Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana.Spelling : dateColumn #1029

Open
lwandz13 opened this issue Feb 5, 2025 · 3 comments
Open

Grafana.Spelling : dateColumn #1029

lwandz13 opened this issue Feb 5, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@lwandz13
Copy link
Contributor

lwandz13 commented Feb 5, 2025

dateColumn is frequently used with macros, and I feel it should be added to vale.

See issue grafana/grafana#99908. Hung up multiple times due to dateColumn

@lwandz13 lwandz13 added the enhancement New feature or request label Feb 5, 2025
@robbymilo robbymilo removed their assignment Feb 6, 2025
@jdbaldry
Copy link
Member

jdbaldry commented Feb 7, 2025

Similar to #1031 I don't think dateColumn is a word and it should instead be enclosed in code which isn't spellchecked.

@jdbaldry jdbaldry closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2025
@lwandz13
Copy link
Contributor Author

lwandz13 commented Feb 13, 2025

I cannot enclose dateColumn in ticks in several instances. It's a SQL column and it shows up in query results. The SQL would not be formed correctly in sample SQL code and the results would not look correct. Can we add this to the word list? I can use the rule at the top of every SQL-based query editor doc, but it would be easier to just have dateColumn in the word list.

@lwandz13 lwandz13 reopened this Feb 13, 2025
@jdbaldry
Copy link
Member

It's a SQL column and it shows up in query results.

I believe query results would be semantically enclosed in code blocks which are also not spell checked.

The SQL would not be formed correctly in sample SQL code and the results would not look correct.

If the use of dateColumn is already inside a code block or inline code, then you wouldn't need extra backticks, because it already wouldn't be spell checked because the linter knows that it's "code".

Can we add this to the word list?

dateColumn isn't a word, it's a macro name which is code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants