small refinements

Author: michalmac

.gitignore

@@ -11,4 +11,5 @@
 
 # Eclipse
 .project
-.classpath
+.classpath
+/.settings/

jsprit-core/src/main/java/com/graphhopper/jsprit/core/problem/Skills.java

@@ -109,7 +109,7 @@ public String toString() {
      * @return true if skill is included, false otherwise
      */
     public boolean containsSkill(String skill) {
-        return skills.contains(skill.toLowerCase());
+        return skills.contains(skill.trim().toLowerCase());// trim to be consistent with addSkill()
     }
 
     @Override

jsprit-core/src/main/java/com/graphhopper/jsprit/core/util/Coordinate.java

@@ -23,9 +23,9 @@ public static Coordinate newInstance(double x, double y) {
         return new Coordinate(x, y);
     }
 
-    private double x;
+    private final double x;
 
-    private double y;
+    private final double y;
 
     public Coordinate(double x, double y) {
         super();

jsprit-core/src/main/java/com/graphhopper/jsprit/core/util/EuclideanCosts.java

@@ -60,11 +60,8 @@ public double getTransportCost(Location from, Location to, double time, Driver d
     private double calculateDistance(Location fromLocation, Location toLocation) {
         Coordinate from = null;
         Coordinate to = null;
-        if (fromLocation.getCoordinate() != null & toLocation.getCoordinate() != null) {
-            from = fromLocation.getCoordinate();
-            to = toLocation.getCoordinate();
-        }
-        if (from == null || to == null) throw new NullPointerException();
+        from = fromLocation.getCoordinate();
+        to = toLocation.getCoordinate();
         return calculateDistance(from, to);
     }
 

jsprit-examples/.gitignore

@@ -13,3 +13,4 @@
 .project
 .classpath
 .settings
+/.factorypath