feat: register new dispute manager in controller overriding old one

Signed-off-by: Tomás Migone <[email protected]>

Author: tmigone

packages/horizon/ignition/configs/migrate.arbitrumSepolia.json5

@@ -30,7 +30,9 @@
     "horizonStakingImplementationAddress": "0x2AF6F51e119A79497C3A3FFf012B5889da489764",
     "curationImplementationAddress": "0xbC8F4355f346e47eef8A0DBFF4a58616ACf7DaCA",
     "rewardsManagerImplementationAddress": "0x856843F6409a8b3A0d4aaE67313037FED02bBBFf",
-
+    "disputeManagerAddress": "0x96e1b86b2739e8A3d59F40F2532caDF9cE8Da088",
+    
+    // Must be set for step 5 of the migration
     // Global parameters
     "maxThawingPeriod": 2419200
   },

packages/horizon/ignition/configs/migrate.default.json5

@@ -30,6 +30,7 @@
     "horizonStakingImplementationAddress": "",
     "curationImplementationAddress": "",
     "rewardsManagerImplementationAddress": "",
+    "disputeManagerAddress": "",
 
     // Global parameters
     "maxThawingPeriod": 2419200

packages/horizon/ignition/configs/migrate.integration.json5

@@ -30,6 +30,7 @@
     "horizonStakingImplementationAddress": "",
     "curationImplementationAddress": "",
     "rewardsManagerImplementationAddress": "",
+    "disputeManagerAddress": "",
 
     // Global parameters
     "maxThawingPeriod": 2419200

packages/horizon/ignition/configs/migrate.localNetwork.json5

@@ -30,6 +30,7 @@
     "horizonStakingImplementationAddress": "",
     "curationImplementationAddress": "",
     "rewardsManagerImplementationAddress": "",
+    "disputeManagerAddress": "",
 
     // Global parameters
     "maxThawingPeriod": 2419200

packages/horizon/ignition/configs/protocol.default.json5

@@ -6,6 +6,7 @@
 
     // Placeholder address for a standalone Horizon deployment, see README.md for more details
     "subgraphServiceAddress": "0x0000000000000000000000000000000000000000",
+    "disputeManagerAddress": "0x0000000000000000000000000000000000000001",
 
     // Global parameters
     "maxThawingPeriod": 2419200

packages/horizon/ignition/configs/protocol.localNetwork.json5

@@ -6,6 +6,7 @@
 
     // Placeholder address for a standalone Horizon deployment, see README.md for more details
     "subgraphServiceAddress": "0x0000000000000000000000000000000000000000",
+    "disputeManagerAddress": "0x0000000000000000000000000000000000000001",
 
     // Global parameters
     "maxThawingPeriod": 2419200

packages/horizon/ignition/modules/migrate/migrate-4.ts

@@ -1,4 +1,6 @@
+import ControllerArtifact from '@graphprotocol/contracts/artifacts/contracts/governance/Controller.sol/Controller.json'
 import { buildModule } from '@nomicfoundation/hardhat-ignition/modules'
+import { ethers } from 'ethers'
 
 import { MigrateHorizonStakingGovernorModule } from '../core/HorizonStaking'
 import { MigrateCurationGovernorModule } from '../periphery/Curation'
@@ -9,5 +11,13 @@ export default buildModule('GraphHorizon_Migrate_4', (m) => {
   m.useModule(MigrateRewardsManagerGovernorModule)
   m.useModule(MigrateHorizonStakingGovernorModule)
 
+  // Patch controller to override old dispute manager address
+  const disputeManagerAddress = m.getParameter('disputeManagerAddress')
+  const controllerAddress = m.getParameter('controllerAddress')
+  const Controller = m.contractAt('Controller', ControllerArtifact, controllerAddress)
+  m.call(Controller, 'setContractProxy', [ethers.keccak256(ethers.toUtf8Bytes('DisputeManager')), disputeManagerAddress], {
+    id: 'setContractProxy_DisputeManager',
+  })
+
   return {}
 })

packages/horizon/ignition/modules/periphery/periphery.ts

@@ -21,6 +21,8 @@ export default buildModule('GraphHorizon_Periphery', (m) => {
   const { L2GraphTokenGateway, L2GraphTokenGatewayImplementation } = m.useModule(GraphTokenGatewayModule)
   const { L2GraphToken, L2GraphTokenImplementation } = m.useModule(GraphTokenModule)
 
+  const disputeManagerAddress = m.getParameter('disputeManagerAddress')
+
   m.call(Controller, 'setContractProxy', [ethers.keccak256(ethers.toUtf8Bytes('EpochManager')), EpochManager], {
     id: 'setContractProxy_EpochManager',
   })
@@ -45,6 +47,9 @@ export default buildModule('GraphHorizon_Periphery', (m) => {
   m.call(Controller, 'setContractProxy', [ethers.keccak256(ethers.toUtf8Bytes('GNS')), L2GNS], {
     id: 'setContractProxy_L2GNS',
   })
+  m.call(Controller, 'setContractProxy', [ethers.keccak256(ethers.toUtf8Bytes('DisputeManager')), disputeManagerAddress], {
+    id: 'setContractProxy_DisputeManager',
+  })
 
   return {
     Controller,

packages/horizon/tasks/deploy.ts

@@ -163,6 +163,16 @@ function _patchStepConfig<ChainId extends number, ContractName extends string, H
     return subgraphServiceAddressBook.getEntry('SubgraphService').address
   }
 
+  // Get the dispute manager address
+  // Dispute manager address book might exist if we are running horizon + subgraph service
+  // or it might not exist if we are running horizon standalone
+  function getDisputeManagerAddress() {
+    if (subgraphServiceAddressBook === undefined || !subgraphServiceAddressBook.entryExists('DisputeManager') || standalone) {
+      return ZERO_ADDRESS
+    }
+    return subgraphServiceAddressBook.getEntry('DisputeManager').address ?? ZERO_ADDRESS
+  }
+
   switch (step) {
     case 2:
       const GraphPayments = horizonAddressBook.getEntry('GraphPayments')
@@ -188,6 +198,7 @@ function _patchStepConfig<ChainId extends number, ContractName extends string, H
       patchedConfig = patchConfig(patchedConfig, {
         $global: {
           subgraphServiceAddress: getSubgraphServiceAddress(),
+          disputeManagerAddress: getDisputeManagerAddress(),
           horizonStakingImplementationAddress: HorizonStaking.implementation ?? ZERO_ADDRESS,
           curationImplementationAddress: L2Curation.implementation ?? ZERO_ADDRESS,
           rewardsManagerImplementationAddress: RewardsManager.implementation ?? ZERO_ADDRESS,