Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove requirement to singledispatch for python >= 3.4 #303

Closed
jbvsmo opened this issue Apr 25, 2021 · 2 comments
Closed

Remove requirement to singledispatch for python >= 3.4 #303

jbvsmo opened this issue Apr 25, 2021 · 2 comments

Comments

@jbvsmo
Copy link

jbvsmo commented Apr 25, 2021 •
edited
Loading

It is very weird that this library is being used. It is 6 months old and zero stars on github (https://github.com/jaraco/singledispatch).
Also this lib emits a warning regarding collections.abc

The functionality was added to functools on python 3.4 and so this should be a conditional requirement for people stuck in older unsupported python versions. Same thing was done to enum so please do the same here.
@zsiciarz
Copy link
Contributor

This has been addressed in #317 .

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related topics referencing this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zsiciarz @jbvsmo @erikwrede