Fix test_builds_a_schema_with_field_arguments_with_default_values.

Author: jnak

graphql/execution/tests/test_executor_thread.py

@@ -19,7 +19,7 @@
 
 ###
 # Disabled because all these tests are flaky
-# The culprit lies in the fact that the `ThreadExecutor` incorrectly assumes that
+# The culprit is that the `ThreadExecutor` incorrectly assumes that
 # the `Promise` class is thread-safe.
 # See https://git.io/JeA3s
 ###

graphql/type/definition.py

@@ -649,7 +649,7 @@ def __init__(
         self.name = name
         self.description = description
         if container_type is None:
-            container_type = dict  # type: ignore
+            container_type = OrderedDict  # type: ignore
         assert callable(container_type), "container_type must be callable"
         self.container_type = container_type
         self._fields = fields

graphql/utils/value_from_ast.py

@@ -1,4 +1,5 @@
 from ..language import ast
+from ..pyutils.ordereddict import OrderedDict
 from ..type import (
     GraphQLEnumType,
     GraphQLInputObjectType,
@@ -56,13 +57,15 @@ def value_from_ast(value_ast, type, variables=None):
         for field_ast in value_ast.fields:
             field_asts[field_ast.name.value] = field_ast
 
-        obj = {}
+        obj_items = []
         for field_name, field in fields.items():
             if field_name not in field_asts:
                 if field.default_value is not None:
                     # We use out_name as the output name for the
                     # dict if exists
-                    obj[field.out_name or field_name] = field.default_value
+                    obj_items.append(
+                        (field.out_name or field_name, field.default_value)
+                    )
 
                 continue
 
@@ -72,7 +75,9 @@ def value_from_ast(value_ast, type, variables=None):
 
             # We use out_name as the output name for the
             # dict if exists
-            obj[field.out_name or field_name] = field_value
+            obj_items.append((field.out_name or field_name, field_value))
+
+        obj = OrderedDict(obj_items)
 
         return type.create_container(obj)