From c674c8fef851db6986b67e7690a5587a8af12f42 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Mon, 23 Sep 2024 13:18:10 +0300 Subject: [PATCH 01/11] add draft --- .../tutorials/whats-new-in-graphql-js-v17.md | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 website/docs/tutorials/whats-new-in-graphql-js-v17.md diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md new file mode 100644 index 0000000000..b90505bdb7 --- /dev/null +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -0,0 +1,52 @@ +# What's New in graphql-js v17? + +## Specification Changes + +### New Experimental Features + +#### Experimental Support for Incremental Delivery + +- enabled only when using `experimentalExecuteIncrementally()`, use of a schema or operation with `@defer`/`@stream` directives within `execute()` will now throw. +- enable early execution with the new `enableEarlyExecution` configuration option for `experimentalExecuteIncrementally()`. + +#### Experimental Support for Fragment Arguments + +- enable with the new `experimentalFragmentArguments` configuration option for `parse()`. +- new experimental `Kind.FRAGMENT_ARGUMENT` for visiting +- new experimental `TypeInfo` methods and options for handling fragment arguments. +- coerce AST via new function `coerceInputLiteral()` with experimental fragment variables argument (as opposed to deprecated `valueFromAST()` function). + +### Clarifications + +- Fix ambiguity around when schema definition may be omitted (#3839) +- No reusing root types (#3453) + +## New API features + +- Use `coerceInputLiteral()` instead of `valueFromAST()`. +- Support for resolver functions returning async iterables. +- Expose `printDirective()` helper function. + +## API Changes: + +- Changes to the `subscribe()` function: + - `subscribe()` may now return a non-promise. + - When a subscription root field errors, `subscribe()` now returns a well-formatted `GraphQLError` rather than throwing. +- Properly type `IntrospectionType` using `TypeKind` Enum. + +## Deprecations + +- `valueFromAST()` is deprecated, use `coerceInputLiteral()` instead. + +## Removals + +- Removed deprecated `graphql/subscription` module, use `graphql/execution` instead +- Removed deprecated `getOperationRootType()` #3571, use `schema.getRootType()` instead. +- Remove deprecated `assertValidName()` and `isValidNameError()`, use `assertName()` instead. +- Removed deprecated custom `TypeInfo` argument for `validate()`. +- Remove deprecated custom `getFieldDefFn()` argument for `TypeInfo` constructor. To customize field resolution, one can subclass the `GraphQLSchema` class and override the `getField()` method. +- Remove deprecated positional arguments for the `GraphQLError` constructor. +- Remove deprecated distinct Enum types: `KindEnum`, `TokenKindEnum`, and `DirectiveLocationEnum`. +- Remove deprecated `getVisitFn()` helper function, use `getEnterLeaveForKind()` instead. +- Remove deprecated `formatError()` and `printError()` helper sfunctions, use `error.toString()` and `error.toJSON()` methods instead. +- Remove deprecated positional arguments for `createSourceEventStream()`. From 5e74665b9f33a38552b5f05ffc9f26d8f5578835 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Mon, 23 Sep 2024 13:57:50 +0300 Subject: [PATCH 02/11] update with links and other edits --- .../tutorials/whats-new-in-graphql-js-v17.md | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index b90505bdb7..95350e34ab 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -1,25 +1,35 @@ -# What's New in graphql-js v17? +# What's New in `graphql-js` v17? -## Specification Changes +## Changes by Way of the Specification ### New Experimental Features #### Experimental Support for Incremental Delivery +- [Spec PR](https://github.com/graphql/graphql-spec/pull/1110) / [RFC](https://github.com/graphql/graphql-wg/blob/main/rfcs/DeferStream.md) - enabled only when using `experimentalExecuteIncrementally()`, use of a schema or operation with `@defer`/`@stream` directives within `execute()` will now throw. - enable early execution with the new `enableEarlyExecution` configuration option for `experimentalExecuteIncrementally()`. #### Experimental Support for Fragment Arguments +- [Spec PR](https://github.com/graphql/graphql-spec/pull/1081) / [RFC](https://github.com/graphql/graphql-wg/blob/main/rfcs/DeferStream.md) - enable with the new `experimentalFragmentArguments` configuration option for `parse()`. - new experimental `Kind.FRAGMENT_ARGUMENT` for visiting - new experimental `TypeInfo` methods and options for handling fragment arguments. - coerce AST via new function `coerceInputLiteral()` with experimental fragment variables argument (as opposed to deprecated `valueFromAST()` function). -### Clarifications +### Specification Clarifications -- Fix ambiguity around when schema definition may be omitted (#3839) -- No reusing root types (#3453) +#### Fix ambiguity around when schema definition may be omitted + +- [Spec PR](https://github.com/graphql/graphql-spec/pull/987) +- Schema definition will include only the proper root types. + +### Implementation Fixes + +#### Enforcing uniqueness of root types + +- `graphql-js` now properly enforces that the schema's root types must be unique. ## New API features @@ -48,5 +58,5 @@ - Remove deprecated positional arguments for the `GraphQLError` constructor. - Remove deprecated distinct Enum types: `KindEnum`, `TokenKindEnum`, and `DirectiveLocationEnum`. - Remove deprecated `getVisitFn()` helper function, use `getEnterLeaveForKind()` instead. -- Remove deprecated `formatError()` and `printError()` helper sfunctions, use `error.toString()` and `error.toJSON()` methods instead. +- Remove deprecated `formatError()` and `printError()` helper functions, use `error.toString()` and `error.toJSON()` methods instead. - Remove deprecated positional arguments for `createSourceEventStream()`. From c9eb8eb246e96b5df05825a0113154cb533f01bf Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Wed, 25 Sep 2024 21:43:12 +0300 Subject: [PATCH 03/11] add default value changes --- website/docs/tutorials/whats-new-in-graphql-js-v17.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index 95350e34ab..4414f03115 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -42,7 +42,11 @@ - Changes to the `subscribe()` function: - `subscribe()` may now return a non-promise. - When a subscription root field errors, `subscribe()` now returns a well-formatted `GraphQLError` rather than throwing. -- Properly type `IntrospectionType` using `TypeKind` Enum. +- Changes to default values: + - The `defaultValue` property of `GraphQLArgument` and `GraphQLInputField` is now of new type `GraphQLDefaultValueUsage`. A `GraphQLDefaultValueUsage` object contains either a `literal` property, which is as AST node representing the parsed default value included within the SDL, or a `value` property, the default value as specified programmatically. + - Introspection now returns the exact original default value included within the SDL rather than attempting to "serialize" input values, avoiding some rare cases in which default values within an introspected schema could differ slightly from the original SDL (e.g. [#3501](https://github.com/graphql/graphql-js/issues/3051)). +- Other Changes: +- `IntrospectionType` is now properly typed using `TypeKind` Enum. ## Deprecations From 5c413081cb6a2df0c2355bb3b75797966e008c13 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Sun, 29 Sep 2024 13:30:46 +0300 Subject: [PATCH 04/11] add changes to Variable Values --- website/docs/tutorials/whats-new-in-graphql-js-v17.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index 4414f03115..57f1466df3 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -47,6 +47,9 @@ - Introspection now returns the exact original default value included within the SDL rather than attempting to "serialize" input values, avoiding some rare cases in which default values within an introspected schema could differ slightly from the original SDL (e.g. [#3501](https://github.com/graphql/graphql-js/issues/3051)). - Other Changes: - `IntrospectionType` is now properly typed using `TypeKind` Enum. +- Changes to Variable Values throughout the code base: + - Variable Values are now a dedicated type containing both the coerced values as before as well as the variable signature and provided source, so that variables embedded within complex scalars will be able to be properly replaced. This is non-spec behavior, but was previously supported by `graphql-js` and will now be sound. + - The return type of `getVariableValues()` has been updated, as have the provided arguments to `getArgumentValues()`, `coerceInputLiteral()`, and `collectFields()`, and `getDirectiveValues()`. ## Deprecations From 7c690df72a658eb21d829ea990ca96a6ee7da0a3 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Sun, 29 Sep 2024 14:49:28 +0300 Subject: [PATCH 05/11] flesh out input coercion changes --- .../docs/tutorials/whats-new-in-graphql-js-v17.md | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index 57f1466df3..966e115b8c 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -33,27 +33,32 @@ ## New API features -- Use `coerceInputLiteral()` instead of `valueFromAST()`. - Support for resolver functions returning async iterables. - Expose `printDirective()` helper function. ## API Changes: +- Changes to input coercion: + - Use new utility `coerceInputLiteral()` instead of `valueFromAST()`. + - Use new utility `replaceVariableValues()` to replace variables within complex scalars uses as inputs. Internally, `replaceVariableValues()` uses new utility `valueToLiteral()` to convert from an external input value to a literal value. This allows variables embedded within complex scalars to use the correct default values. + - Use new utility `valueToLiteral()` to convert from an external input value to a literal value. Custom scalars can define custom behavior by implementing an optional `valueToLiteral()` method. + - Use new `parseConstLiteral()` methods on leaf types instead of `parseLiteral()` to convert literals to values, by first calling new utility `replaceVariableValues()` on the non-constant literal, and then by calling `parseConstLiteral()`. - Changes to the `subscribe()` function: - `subscribe()` may now return a non-promise. - When a subscription root field errors, `subscribe()` now returns a well-formatted `GraphQLError` rather than throwing. +- Changes to Variable Values throughout the code base: + - Variable Values are now a dedicated type containing both the coerced values as before as well as the variable signature and provided source, so that variables embedded within complex scalars will be able to be properly replaced. This is non-spec behavior, but was previously supported by `graphql-js` and will now be sound. + - The return type of `getVariableValues()` has been updated, as have the provided arguments to `getArgumentValues()`, `coerceInputLiteral()`, and `collectFields()`, and `getDirectiveValues()`. - Changes to default values: - The `defaultValue` property of `GraphQLArgument` and `GraphQLInputField` is now of new type `GraphQLDefaultValueUsage`. A `GraphQLDefaultValueUsage` object contains either a `literal` property, which is as AST node representing the parsed default value included within the SDL, or a `value` property, the default value as specified programmatically. - Introspection now returns the exact original default value included within the SDL rather than attempting to "serialize" input values, avoiding some rare cases in which default values within an introspected schema could differ slightly from the original SDL (e.g. [#3501](https://github.com/graphql/graphql-js/issues/3051)). - Other Changes: - `IntrospectionType` is now properly typed using `TypeKind` Enum. -- Changes to Variable Values throughout the code base: - - Variable Values are now a dedicated type containing both the coerced values as before as well as the variable signature and provided source, so that variables embedded within complex scalars will be able to be properly replaced. This is non-spec behavior, but was previously supported by `graphql-js` and will now be sound. - - The return type of `getVariableValues()` has been updated, as have the provided arguments to `getArgumentValues()`, `coerceInputLiteral()`, and `collectFields()`, and `getDirectiveValues()`. ## Deprecations - `valueFromAST()` is deprecated, use `coerceInputLiteral()` instead. +- `parseLiteral()` methods of custom scalars are deprecated, use `parseConstLiteral()` instead. ## Removals From 12f53ac8e58ac70bb0ccc2289a935c58870c65f5 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Mon, 30 Sep 2024 15:47:22 +0300 Subject: [PATCH 06/11] update after the landing of https://github.com/graphql/graphql-js/pull/4209, we don't have any breaking behavior (yet) in terms of input value coercion! --- website/docs/tutorials/whats-new-in-graphql-js-v17.md | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index 966e115b8c..1f775389e0 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -33,16 +33,15 @@ ## New API features +- Use new utility `coerceInputLiteral()` as a replacement for `valueFromAST()`. +- Use new utility `valueToLiteral()` to convert from an external input value to a literal value. Custom scalars can define custom behavior by implementing an optional new `valueToLiteral()` method, otherwise a default conversion function will be used. +- Use new utility `replaceVariableValues()` to replace variables within complex scalars uses as inputs. This allows variables embedded within complex scalars to use the correct default values. +- Use new `parseConstLiteral()` methods on custom scalar types instead of `parseLiteral()` (along with the new `valueToLiteral()` method when required) to automatically convert literals to values, including any variables embedded within complex scalars. Embedded variables will (finally) receive the appropriate default values! Note: `parseLiteral()` has been deprecated; in the next major version, it will be removed and the `parseConstLiteral()` method for custom scalars will be set to a default function when not provided, similar to the current behavior of `parseLiteral()`. - Support for resolver functions returning async iterables. - Expose `printDirective()` helper function. ## API Changes: -- Changes to input coercion: - - Use new utility `coerceInputLiteral()` instead of `valueFromAST()`. - - Use new utility `replaceVariableValues()` to replace variables within complex scalars uses as inputs. Internally, `replaceVariableValues()` uses new utility `valueToLiteral()` to convert from an external input value to a literal value. This allows variables embedded within complex scalars to use the correct default values. - - Use new utility `valueToLiteral()` to convert from an external input value to a literal value. Custom scalars can define custom behavior by implementing an optional `valueToLiteral()` method. - - Use new `parseConstLiteral()` methods on leaf types instead of `parseLiteral()` to convert literals to values, by first calling new utility `replaceVariableValues()` on the non-constant literal, and then by calling `parseConstLiteral()`. - Changes to the `subscribe()` function: - `subscribe()` may now return a non-promise. - When a subscription root field errors, `subscribe()` now returns a well-formatted `GraphQLError` rather than throwing. From c596f82ae110fc2298a7474d09b17ca18ec23f56 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Wed, 27 Nov 2024 14:21:01 +0200 Subject: [PATCH 07/11] major edits, bringing this PR up to date. --- .../tutorials/whats-new-in-graphql-js-v17.md | 63 ++++++++++++------- 1 file changed, 40 insertions(+), 23 deletions(-) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index 1f775389e0..e781a5235e 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -33,41 +33,58 @@ ## New API features -- Use new utility `coerceInputLiteral()` as a replacement for `valueFromAST()`. -- Use new utility `valueToLiteral()` to convert from an external input value to a literal value. Custom scalars can define custom behavior by implementing an optional new `valueToLiteral()` method, otherwise a default conversion function will be used. -- Use new utility `replaceVariableValues()` to replace variables within complex scalars uses as inputs. This allows variables embedded within complex scalars to use the correct default values. -- Use new `parseConstLiteral()` methods on custom scalar types instead of `parseLiteral()` (along with the new `valueToLiteral()` method when required) to automatically convert literals to values, including any variables embedded within complex scalars. Embedded variables will (finally) receive the appropriate default values! Note: `parseLiteral()` has been deprecated; in the next major version, it will be removed and the `parseConstLiteral()` method for custom scalars will be set to a default function when not provided, similar to the current behavior of `parseLiteral()`. -- Support for resolver functions returning async iterables. -- Expose `printDirective()` helper function. +- New `experimentalExecuteIncrementally()` function enables incremental delivery with a schema including the `@defer` and `@stream` directives. +- New `validateExecutionArgs()`, `executeQueryOrMutationOrSubscriptionEvent()`, or `experimentalExecuteQueryOrMutationOrSubscriptionEvent()` helpers are available to perform GraphQL argument evaluation and/or manipulation and then manually continue with execution. +- New `perEventExecutor` option allows specification of a custom executor for subscription source stream events, with the default option set to new helper `executeSubscriptionEvent()`. +- New `abortSignal` option to `graphql()`, `execute()`, and `subscribe()` allows cancellation of these methods; the `abortSignal` can also be passed to field resolvers to cancel asynchronous work that they initiate. +- New `hideSuggestions` option added to `graphql()`, `validate()`, `execute()`, and `subscribe()`; the `getVariableValues()`, `getArgumentValues()`, `getDirectiveValues()`, `coerceInputValue()`, `coerceInputLiteral()`, `collectFields()` helpers; the `ValidationContext` class, as well as the coercion methods for leaf types. The option hides suggestions! +- New utility `findSchemaChanges()` can be used to find safe changes as well as the breaking and dangerous changes returned by `findBreakingChanges()` and `findDangerousChanges()`. The latter two functions are now deprecated. +- New utility `coerceInputLiteral()` replaces `valueFromAST()`. +- New utility `valueToLiteral()` converts from an external input value to a literal value. Custom scalars can define custom behavior by implementing an optional new `valueToLiteral()` method, otherwise a default conversion function will be used. +- New utilities `validateInputValue()` and `validateInputLiteral()` can be used to validate input values and literals, respectively. +- New utility `replaceVariableValues()` can be used to replace variables within complex scalars uses as inputs. This allows variables embedded within complex scalars to use the correct default values. +- New `coerceInputLiteral()` methods on custom scalar types can be used (along with the new `valueToLiteral()` method when required) to automatically convert literals to values, including any variables embedded within complex scalars. Embedded variables will (finally) receive the appropriate default values! The `parseLiteral()` methods have been deprecated. +- New support for resolver functions returning async iterables. +- New helper `printDirective()` function introduced. +- New option to use symbols rather than strings as keys within `extensions` properties of the various GraphQL Schema elements. ## API Changes: +- Changes to the `execute()` function: + - Field resolvers that are still running after the function returns (e.g. when null-bubbling from a rejected asynchronous resolver leads to early return with additional still running asynchronous resolvers) will no longer trigger additional child resolvers. - Changes to the `subscribe()` function: - `subscribe()` may now return a non-promise. - When a subscription root field errors, `subscribe()` now returns a well-formatted `GraphQLError` rather than throwing. +- Changes to the `coerceInputValue()` helper: + - On coercion failure, the function now will return early with `undefined` rather than collecting or throwing errors. If detailed error information is desired, use new utility `validateInputValue()`. - Changes to Variable Values throughout the code base: - - Variable Values are now a dedicated type containing both the coerced values as before as well as the variable signature and provided source, so that variables embedded within complex scalars will be able to be properly replaced. This is non-spec behavior, but was previously supported by `graphql-js` and will now be sound. + - Variable Values are now a dedicated type containing both the coerced values as before as well as the variable signature and provided source, so that variables embedded within complex scalars will be able to be properly replaced. - The return type of `getVariableValues()` has been updated, as have the provided arguments to `getArgumentValues()`, `coerceInputLiteral()`, and `collectFields()`, and `getDirectiveValues()`. -- Changes to default values: - - The `defaultValue` property of `GraphQLArgument` and `GraphQLInputField` is now of new type `GraphQLDefaultValueUsage`. A `GraphQLDefaultValueUsage` object contains either a `literal` property, which is as AST node representing the parsed default value included within the SDL, or a `value` property, the default value as specified programmatically. - - Introspection now returns the exact original default value included within the SDL rather than attempting to "serialize" input values, avoiding some rare cases in which default values within an introspected schema could differ slightly from the original SDL (e.g. [#3501](https://github.com/graphql/graphql-js/issues/3051)). -- Other Changes: -- `IntrospectionType` is now properly typed using `TypeKind` Enum. +- Changes to AST nodes: + - AST node properties have been optimized to use `undefined` rather than empty arrays. +- Enum Changes: + - `IntrospectionType` is now properly typed using `TypeKind` Enum. + - The `Kind` enum has been changes from a TypeScript Enum to an object literal. A `Kind` type is still exported, such that `typeof Kind` is not the same as the `Kind` type. +- Change to `GraphQLSchema` configuration: + - The `assumeValid` config property exported by the `GraphQLSchema.toConfig()` method now passes through the original flag passed on creation of the `GraphQLSchema`. Previously, the `assumeValid` property would be to `true` if validation had been run, potentially concealing the original intent. ## Deprecations - `valueFromAST()` is deprecated, use `coerceInputLiteral()` instead. -- `parseLiteral()` methods of custom scalars are deprecated, use `parseConstLiteral()` instead. +- `parse()` methods of leaf types are deprecated, use `coerceInputValue()` instead. +- `parseLiteral()` methods of leaf types are deprecated, use `coerceInputLiteral()` instead. +- `serialize()` methods of leaf types are deprecated, use `coerceOutputValue()` instead. +- `findBreakingChanges()` and `findDangerousChanges()` are deprecated, use `findSchemaChanges()` instead. ## Removals -- Removed deprecated `graphql/subscription` module, use `graphql/execution` instead -- Removed deprecated `getOperationRootType()` #3571, use `schema.getRootType()` instead. -- Remove deprecated `assertValidName()` and `isValidNameError()`, use `assertName()` instead. -- Removed deprecated custom `TypeInfo` argument for `validate()`. -- Remove deprecated custom `getFieldDefFn()` argument for `TypeInfo` constructor. To customize field resolution, one can subclass the `GraphQLSchema` class and override the `getField()` method. -- Remove deprecated positional arguments for the `GraphQLError` constructor. -- Remove deprecated distinct Enum types: `KindEnum`, `TokenKindEnum`, and `DirectiveLocationEnum`. -- Remove deprecated `getVisitFn()` helper function, use `getEnterLeaveForKind()` instead. -- Remove deprecated `formatError()` and `printError()` helper functions, use `error.toString()` and `error.toJSON()` methods instead. -- Remove deprecated positional arguments for `createSourceEventStream()`. +- Deprecated `graphql/subscription` module has been removed, use `graphql/execution` instead +- Deprecated `getOperationRootType()` #3571 has been removed, use `schema.getRootType()` instead. +- Deprecated `assertValidName()` and `isValidNameError()` has been removed, use `assertName()` instead. +- Deprecated custom `TypeInfo` argument for `validate()` has been removed. +- Deprecated custom `getFieldDefFn()` argument for `TypeInfo` constructor has been removed. To customize field resolution, one can subclass the `GraphQLSchema` class and override the `getField()` method. +- Deprecated positional arguments for the `GraphQLError` constructor have been removed. +- Deprecated distinct Enum types `KindEnum`, `TokenKindEnum`, and `DirectiveLocationEnum` have been removed. +- Deprecated `getVisitFn()` helper function has been removed, use `getEnterLeaveForKind()` instead. +- Deprecated `formatError()` and `printError()` helper functions have been removed, use `error.toString()` and `error.toJSON()` methods instead. +- Deprecated positional arguments for `createSourceEventStream()` have been removed. From e4b14bbc31d209577caedb6a1d54a4770d22d6e9 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Wed, 27 Nov 2024 14:32:50 +0200 Subject: [PATCH 08/11] f --- website/docs/tutorials/whats-new-in-graphql-js-v17.md | 1 - 1 file changed, 1 deletion(-) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index e781a5235e..311890b657 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -33,7 +33,6 @@ ## New API features -- New `experimentalExecuteIncrementally()` function enables incremental delivery with a schema including the `@defer` and `@stream` directives. - New `validateExecutionArgs()`, `executeQueryOrMutationOrSubscriptionEvent()`, or `experimentalExecuteQueryOrMutationOrSubscriptionEvent()` helpers are available to perform GraphQL argument evaluation and/or manipulation and then manually continue with execution. - New `perEventExecutor` option allows specification of a custom executor for subscription source stream events, with the default option set to new helper `executeSubscriptionEvent()`. - New `abortSignal` option to `graphql()`, `execute()`, and `subscribe()` allows cancellation of these methods; the `abortSignal` can also be passed to field resolvers to cancel asynchronous work that they initiate. From 3a8ea220ae00d2ea6cac06ca5063eb44eaac2e48 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Wed, 27 Nov 2024 14:38:48 +0200 Subject: [PATCH 09/11] restore default value bit --- website/docs/tutorials/whats-new-in-graphql-js-v17.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index 311890b657..170be315af 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -31,6 +31,10 @@ - `graphql-js` now properly enforces that the schema's root types must be unique. +#### Default Values + +- Use external GraphQL values for the programmatic `defaultValue` property of `GraphQLArgument` and `GraphQLInputField` objects rather than coerced internal default value. Introspection will then present the exact original default value rather than attempting to "uncoerce" internal input values, avoiding some rare cases in which default values within an introspected schema could differ slightly from the original SDL (e.g. [#3501](https://github.com/graphql/graphql-js/issues/3051)). + ## New API features - New `validateExecutionArgs()`, `executeQueryOrMutationOrSubscriptionEvent()`, or `experimentalExecuteQueryOrMutationOrSubscriptionEvent()` helpers are available to perform GraphQL argument evaluation and/or manipulation and then manually continue with execution. @@ -87,3 +91,4 @@ - Deprecated `getVisitFn()` helper function has been removed, use `getEnterLeaveForKind()` instead. - Deprecated `formatError()` and `printError()` helper functions have been removed, use `error.toString()` and `error.toJSON()` methods instead. - Deprecated positional arguments for `createSourceEventStream()` have been removed. + for `createSourceEventStream()`. From f93f3694cc0f294ed14101a6423e3e736f6cb913 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Wed, 27 Nov 2024 14:39:24 +0200 Subject: [PATCH 10/11] remove some nonsense --- website/docs/tutorials/whats-new-in-graphql-js-v17.md | 1 - 1 file changed, 1 deletion(-) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index 170be315af..4d2fa25604 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -91,4 +91,3 @@ - Deprecated `getVisitFn()` helper function has been removed, use `getEnterLeaveForKind()` instead. - Deprecated `formatError()` and `printError()` helper functions have been removed, use `error.toString()` and `error.toJSON()` methods instead. - Deprecated positional arguments for `createSourceEventStream()` have been removed. - for `createSourceEventStream()`. From c858663335e65abc3512b1969669ebfed3846f54 Mon Sep 17 00:00:00 2001 From: Yaacov Rydzinski Date: Wed, 27 Nov 2024 14:40:15 +0200 Subject: [PATCH 11/11] reorder! --- website/docs/tutorials/whats-new-in-graphql-js-v17.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/website/docs/tutorials/whats-new-in-graphql-js-v17.md b/website/docs/tutorials/whats-new-in-graphql-js-v17.md index 4d2fa25604..fcaadad161 100644 --- a/website/docs/tutorials/whats-new-in-graphql-js-v17.md +++ b/website/docs/tutorials/whats-new-in-graphql-js-v17.md @@ -37,6 +37,7 @@ ## New API features +- New support for resolver functions returning async iterables. - New `validateExecutionArgs()`, `executeQueryOrMutationOrSubscriptionEvent()`, or `experimentalExecuteQueryOrMutationOrSubscriptionEvent()` helpers are available to perform GraphQL argument evaluation and/or manipulation and then manually continue with execution. - New `perEventExecutor` option allows specification of a custom executor for subscription source stream events, with the default option set to new helper `executeSubscriptionEvent()`. - New `abortSignal` option to `graphql()`, `execute()`, and `subscribe()` allows cancellation of these methods; the `abortSignal` can also be passed to field resolvers to cancel asynchronous work that they initiate. @@ -47,7 +48,6 @@ - New utilities `validateInputValue()` and `validateInputLiteral()` can be used to validate input values and literals, respectively. - New utility `replaceVariableValues()` can be used to replace variables within complex scalars uses as inputs. This allows variables embedded within complex scalars to use the correct default values. - New `coerceInputLiteral()` methods on custom scalar types can be used (along with the new `valueToLiteral()` method when required) to automatically convert literals to values, including any variables embedded within complex scalars. Embedded variables will (finally) receive the appropriate default values! The `parseLiteral()` methods have been deprecated. -- New support for resolver functions returning async iterables. - New helper `printDirective()` function introduced. - New option to use symbols rather than strings as keys within `extensions` properties of the various GraphQL Schema elements.