Skip to content

Commit 3441a2d

Browse files
authored
Update criteria scores based on crowd-sourced opinions (#1686)
1 parent 56dc185 commit 3441a2d

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

β€Žrfcs/SemanticNullability.md

+11-11
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ chosen, so this criteria is only concerned with traditionally nullable types.
230230
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
231231
| βœ… | βœ… | βœ… | βœ… | πŸš«πŸ‘ | βœ… |
232232

233-
Criteria score: πŸ₯‡
233+
Criteria score: πŸ₯ˆ
234234

235235
## 🎯 B. Existing executable documents should retain validity and meaning
236236

@@ -244,7 +244,7 @@ same meaning as they always did.
244244
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
245245
| βœ… | 🚫 | βœ… | βœ… | βœ… | βœ… |
246246

247-
Criteria score: πŸ₯‡
247+
Criteria score: πŸ₯ˆ
248248

249249
## 🎯 C. Unadorned type should mean nullable
250250

@@ -258,7 +258,7 @@ and our changes should not invalidate this content.
258258
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
259259
| βœ… | 🚫 | βœ… | 🚫 | βœ… | βœ… |
260260

261-
Criteria score: πŸ₯ˆ
261+
Criteria score: πŸ₯‰
262262

263263
## 🎯 D. Syntax should be obvious to programmers
264264

@@ -272,7 +272,7 @@ GraphQL.
272272
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
273273
| 🚫 | βœ… | βœ… | βœ… | ⚠️ | βœ… |
274274

275-
Criteria score: πŸ₯ˆ
275+
Criteria score: πŸ₯‡
276276

277277
## 🎯 E. Syntax used in SDL and in executable documents should be consistent with SDL
278278

@@ -315,7 +315,7 @@ shine and not compromising the resiliency of legacy deployed app versions.
315315
| --------------- | --------------- | --------------- | --------------- |-----------------|-----------------|
316316
| βœ… | βœ… | βœ… | βœ… | 🚫 | βœ… |
317317

318-
Criteria score: πŸ₯‡
318+
Criteria score: πŸ₯ˆ
319319

320320
* βœ‚οΈ Objection: proposal to lower the score to πŸ₯ˆ. With enough advance notice and a clear upgrade
321321
path for legacy apps, the tradeoff might be acceptable.
@@ -330,7 +330,7 @@ The implementation required to make the proposal work should be simple.
330330
| --------------- | --------------- | --------------- | --------------- |-----------------|-----------------|
331331
| βœ… | 🚫 | 🚫 | 🚫 | βœ… | βœ… |
332332

333-
Criteria score: πŸ₯ˆ
333+
Criteria score: πŸ₯‡
334334

335335
## 🎯 I. Syntax used in executable documents should be unchanged
336336

@@ -345,7 +345,7 @@ executable documents to change.
345345
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
346346
| βœ… | ❔ | βœ… | 🚫 | βœ… | βœ… |
347347

348-
Criteria score: πŸ₯‡
348+
Criteria score: πŸ₯ˆ
349349

350350
## 🎯 J. Type reasoning should remain local
351351

@@ -371,7 +371,7 @@ We do not want to break existing tooling.
371371
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
372372
| βœ… | ❔ | βœ… | ❔ | βœ… | βœ… |
373373

374-
Criteria score: πŸ₯‡
374+
Criteria score: πŸ₯ˆ
375375

376376
## 🎯 L. General GraphQL consumers should only need to think about nullable vs non-nullable
377377

@@ -387,7 +387,7 @@ May contradict: M
387387
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
388388
| βœ… | ❔ | βœ… | ❔ | βœ… | ⚠️ |
389389

390-
Criteria score: πŸ₯‡
390+
Criteria score: πŸ₯ˆ
391391

392392
## 🎯 M. The SDL should have exactly one form used by all producers and consumers
393393

@@ -419,7 +419,7 @@ non-nullable positions.
419419
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
420420
| βœ… | βœ… | βœ… | βœ… | 🚫 | βœ… |
421421

422-
Criteria score: πŸ₯‡
422+
Criteria score: πŸ₯‰
423423

424424
## 🎯 O. Should not have breaking changes for existing executable documents
425425

@@ -510,7 +510,7 @@ wrapper) should be unchanged
510510
|-----------------|-----------------|-----------------|-----------------|-----------------|-----------------|
511511
| βœ… | ❔ | βœ… | 🚫 | βœ… | βœ… |
512512

513-
Criteria score: πŸ₯‡
513+
Criteria score: πŸ₯ˆ
514514

515515
<!--
516516

0 commit comments

Comments
Β (0)