chore(lint): ts for lint and build

Author: draedful

.eslintrc

@@ -5,17 +5,13 @@
     "@gravity-ui/eslint-config/prettier",
     "prettier"
   ],
-  "parserOptions": {
-    "project": "./tsconfig.eslint.json"
-  },
   "root": true,
   "env": {
     "node": true,
     "jest": true
   },
   "overrides": [
     {
-      // enable the rule specifically for TypeScript files
       "files": [
         "*.ts",
         "*.mts",
@@ -32,8 +28,8 @@
               "constructors": "no-public",
               "methods": "explicit",
               "properties": "off",
-              "parameterProperties": "explicit",
-            },
+              "parameterProperties": "explicit"
+            }
           }
         ],
         "no-bitwise": [
@@ -44,31 +40,10 @@
         ]
       }
     },
-    {
-      "files": [
-        "packages/stories/src/**/*.tsx"
-      ],
-      "rules": {
-        "no-console": "off"
-      }
-    },
-    {
-      "files": [
-        "**/*.test.ts",
-        "**/*.test.tsx",
-        "**/*.spec.ts",
-        "**/*.spec.tsx"
-      ],
-      "rules": {
-        "@typescript-eslint/no-explicit-any": "off",
-        "import/no-extraneous-dependencies": "off"
-      }
-    },
     {
       "files": [
         "jest.config.ts",
-        "jest.config.base.ts",
-        "**/jest.config.ts"
+        "jest.config.base.ts"
       ],
       "rules": {
         "import/no-extraneous-dependencies": "off"

packages/graph/.eslintrc.cjs

@@ -0,0 +1,17 @@
+module.exports = {
+  extends: "../../.eslintrc",
+  parserOptions: {
+    project: "./tsconfig.dev.json",
+    tsconfigRootDir: __dirname,
+  },
+  overrides: [
+    {
+      files: ["**/*.test.ts", "**/*.test.tsx", "**/*.spec.ts", "**/*.spec.tsx"],
+      rules: {
+        "@typescript-eslint/no-explicit-any": "off",
+        "import/no-extraneous-dependencies": "off",
+      },
+    },
+  ],
+};
+

packages/graph/src/graph.test.ts

@@ -29,6 +29,8 @@ describe("Graph export/import and updateBlock integration", () => {
       graph2.start();
       const updatedHeight = block.height + 10;
       expect(() => {
+        // First block is guaranteed to exist in exported config
+        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
         graph2.api.updateBlock({ ...exportedConfig.blocks![0]!, height: updatedHeight });
       }).not.toThrow();
       const updatedBlock = graph2.rootStore.blocksList.$blocks.value[0];

packages/graph/src/services/Layer.ts

@@ -59,9 +59,9 @@ export class Layer<
 > extends Component<Props, State, Context> {
   public static id?: string;
 
-  protected canvas!: HTMLCanvasElement;
+  protected canvas?: HTMLCanvasElement;
 
-  protected html!: HTMLElement;
+  protected html?: HTMLElement;
 
   protected root?: HTMLDivElement;
 

packages/graph/src/store/block/BlocksList.test.ts

@@ -2,11 +2,10 @@ import { jest } from "@jest/globals";
 
 import { TBlock } from "../../components/canvas/blocks/Block";
 import { Graph } from "../../graph";
-import { SelectionEvent } from "../../graphEvents";
+import { GraphEventsDefinitions } from "../../graphEvents";
 import { ESelectionStrategy } from "../../services/selection/types";
 import { EAnchorType } from "../anchor/Anchor";
 
-import { TBlockId } from "./Block";
 import { BlockListStore } from "./BlocksList";
 
 const generateBlock = (): TBlock => {
@@ -150,16 +149,16 @@ describe("Blocks selection", () => {
   it.todo("Should emit event on select anchor");
 
   it("Should emit blocks-selection-change event with correct params", () => {
-    const handler = jest.fn();
+    const handler = jest.fn<GraphEventsDefinitions["blocks-selection-change"]>();
     graph.on("blocks-selection-change", handler);
 
     store.updateBlocksSelection([block1.id], true);
 
     expect(handler).toHaveBeenCalledTimes(1);
     const eventArg = handler.mock.calls[0][0];
     // Проверяем, что в eventArg есть нужные id
-    expect((eventArg as SelectionEvent<TBlockId>).detail.changes.add).toEqual([block1.id]);
-    expect((eventArg as SelectionEvent<TBlockId>).detail.changes.removed).toEqual([]);
+    expect(eventArg.detail.changes.add).toEqual([block1.id]);
+    expect(eventArg.detail.changes.removed).toEqual([]);
   });
 
   it("Should prevent selection change if preventDefault called", () => {
@@ -208,7 +207,7 @@ describe("Anchors selection", () => {
   });
 
   it("Should emit block-anchor-selection-change event with correct params", () => {
-    const handler = jest.fn();
+    const handler = jest.fn<GraphEventsDefinitions["block-anchor-selection-change"]>();
     graph.on("block-anchor-selection-change", handler);
 
     store.setAnchorSelection(block.id, anchorId, true);

packages/graph/tsconfig.dev.json

@@ -0,0 +1,16 @@
+{
+  "extends": "./tsconfig.json",
+  "compilerOptions": {
+    "composite": false,
+    "noEmit": true
+  },
+  "include": [
+    "src/**/*"
+  ],
+  "exclude": [
+    "dist",
+    "build",
+    "**/__snapshots__"
+  ]
+}
+

packages/react/.eslintrc.cjs

@@ -0,0 +1,17 @@
+module.exports = {
+  extends: "../../.eslintrc",
+  parserOptions: {
+    project: "./tsconfig.dev.json",
+    tsconfigRootDir: __dirname,
+  },
+  overrides: [
+    {
+      files: ["**/*.test.ts", "**/*.test.tsx", "**/*.spec.ts", "**/*.spec.tsx"],
+      rules: {
+        "@typescript-eslint/no-explicit-any": "off",
+        "import/no-extraneous-dependencies": "off",
+      },
+    },
+  ],
+};
+

packages/react/src/GraphPortal.test.tsx

@@ -5,7 +5,7 @@ import { jest } from "@jest/globals";
 import { act, render, waitFor } from "@testing-library/react";
 
 import { GraphCanvas } from "./GraphCanvas";
-import { GraphPortal } from "./GraphPortal";
+import { GraphPortal, TGraphPortalChildren } from "./GraphPortal";
 
 describe("GraphPortal", () => {
   let graph: Graph;
@@ -66,7 +66,7 @@ describe("GraphPortal", () => {
   });
 
   it("should render children as function with layer parameter", async () => {
-    const childrenFn = jest.fn().mockReturnValue(<div>Function Content</div>);
+    const childrenFn = jest.fn<TGraphPortalChildren>().mockReturnValue(<div>Function Content</div>);
 
     render(
       <GraphCanvas graph={graph} renderBlock={() => <div>Block</div>}>

packages/react/src/GraphPortal.tsx

@@ -51,6 +51,8 @@ class GraphPortalLayer extends Layer<GraphPortalLayerProps, LayerContext, TCompo
   }
 }
 
+export type TGraphPortalChildren = (layer: GraphPortalLayer, graph: Graph) => React.ReactNode;
+
 /**
  * GraphPortal component properties
  */
@@ -71,7 +73,7 @@ export interface GraphPortalProps {
   /**
    * Function for rendering portal content
    */
-  children: React.ReactNode | ((layer: GraphPortalLayer, graph: Graph) => React.ReactNode);
+  children: React.ReactNode | TGraphPortalChildren;
 }
 
 /**

packages/react/src/layer/ReactLayer.test.ts

@@ -1,6 +1,8 @@
 import { Graph } from "@gravity-ui/graph";
 import { jest } from "@jest/globals";
 
+import { TBlockListProps } from "../BlocksList";
+
 import { ReactLayer } from "./ReactLayer";
 
 describe("ReactLayer", () => {
@@ -238,7 +240,7 @@ describe("ReactLayer", () => {
   describe("renderPortal", () => {
     it("should return null when HTML element is forcibly removed", () => {
       const layer = createUnattachedLayer();
-      const renderBlock = jest.fn();
+      const renderBlock = jest.fn<TBlockListProps["renderBlock"]>();
 
       // Mock getHTML to return null
       jest.spyOn(layer, "getHTML").mockReturnValue(null);