Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking record will overwrite existing data without warning the user #175

Open
x0rloser opened this issue Aug 21, 2024 · 4 comments
Open
Labels
enhancement potential new feature

Comments

@x0rloser
Copy link
Contributor

x0rloser commented Aug 21, 2024

When you have captured a packet log in packetry, it will overwrite that log without warning if you then click on the record button.

It may be beneficial to add a warning msgbox to let the user know that they will lose their current packet log if they proceed. This is similar to how wireshark currently treats this situation.

The msgbox could have a tickbox to "do not warn me anymore this session".
Also if the packet log was already saved to disk somewhere, then perhaps the warning msg would not be needed.

@x0rloser
Copy link
Contributor Author

If adding a warning msg, perhaps also add one for when the user attempts to close the app with an unsaved packet log.

@martinling
Copy link
Member

I think the best solution here is probably to add support for having multiple captures open at once (e.g. with a tabbed UI), and then the record button can always start a new capture, without having to dispose of the previous one first.

I'd specifically like to avoid a dialog preventing the record button taking immediate effect.

When debugging hard-to-reproduce issues, it can sometimes take hours or even days to reproduce a problem. Hitting record on a capture device is like pressing the shutter on a camera - it needs to work immediately, or the moment you were trying to capture is lost.

When exiting with unsaved capture data, a dialog makes sense.

@x0rloser
Copy link
Contributor Author

I hear you on the hard to reproduce a problem thing! :)
Which is why it is important to not accidentally lose/overwrite a capture.

@martinling martinling added the enhancement potential new feature label Aug 23, 2024
@mossmann
Copy link
Member

In the meantime we can at least document the current behavior: #183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential new feature
Projects
None yet
Development

No branches or pull requests

3 participants