Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for European phone numbers #295

Open
yamass opened this issue Nov 17, 2019 · 0 comments
Open

Support for European phone numbers #295

yamass opened this issue Nov 17, 2019 · 0 comments

Comments

@yamass
Copy link

yamass commented Nov 17, 2019

Since you asked for it (in the breaking changes section):

Please support different prefixes and notations:

Germany: 0176-12345678 (zero-prefixed with hyphen)
France: 0 590 12 34 56 (zero-prefixed with spaces)
Poland: xx xxx xx xx (any zwo-digit number as prefix and spaces)

There are probably many many more notations and prefix systems. Basically, to support them all, I see two possibilities:

  1. Introduce an flexible API for matchers (I saw a kind of announcement for that in the release notes / breaking changes section)
  2. Write a separate matcher for every possible notation and prefix system and provide fine-grained control which ones get activated or not. The actual matchers could actually be contributed by others if there is a good API (see 1)).

Anyways, thanks for this awesome utility library!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant