Merge pull request #15 from SAY-5/fix-tparens-end-position

fix: include closing paren in TParens end position

Author: robinheghan

src/Compiler/Parse/Type.gren

@@ -171,8 +171,8 @@ term =
                         |> Parser.skip (Parser.chompChar '(' (ExpectedChar '('))
                         |> Parser.skip spaceParser
                         |> Parser.keep expression
-                        |> Parser.keep Parser.getPosition
                         |> Parser.skip (Parser.chompChar ')' (ExpectedChar ')'))
+                        |> Parser.keep Parser.getPosition
                     , Parser.succeed (\record end -> SourcePosition.at start end record)
                         |> Parser.keep recordParser
                         |> Parser.keep Parser.getPosition

tests/src/Test/Compiler/Parse/Type.gren

@@ -91,6 +91,19 @@ tests =
                             { row = 1, col = 3 }
                             (AST.TVar "a")
                     )
+        , test "Parenthesized end position includes closing paren" <| \_ ->
+            Parser.run PT.expression Context.empty "(a)"
+                |> expectLocatedExpression
+                    (SourcePosition.at
+                        { row = 1, col = 1 }
+                        { row = 1, col = 4 }
+                        (AST.TParens <|
+                            SourcePosition.at
+                                { row = 1, col = 2 }
+                                { row = 1, col = 3 }
+                                (AST.TVar "a")
+                        )
+                    )
         , test "Empty Record" <| \_ ->
             Parser.run PT.expression Context.empty "{ }"
                 |> expectExpression
@@ -286,3 +299,13 @@ expectExpression expected result =
 
         Ok { value } ->
             Expect.equal expected value
+
+
+expectLocatedExpression : (SourcePosition.Located a) -> Result (Array (Parser.DeadEnd c e)) (SourcePosition.Located a) -> Expectation
+expectLocatedExpression expected result =
+    when result is
+        Err err ->
+            Expect.fail (Debug.toString err)
+
+        Ok value ->
+            Expect.equal expected value