Skip to content

Commit 9f07887

Browse files
committed
buildscripts: Hard-code use of TLSv1.2 for github download
GitHub is now requiring TLS v1.2: https://githubengineering.com/crypto-removal-notice/ Without this configuration, we see: iwr : The request was aborted: Could not create SSL/TLS secure channel. At line:1 char:5 + & { iwr https://github.com/google/protobuf/archive/v3.5.1.zip -OutFile protobuf. ... + ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidOperation: (System.Net.HttpWebRequest:Htt pWebRequest) [Invoke-WebRequest], WebException + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe ll.Commands.InvokeWebRequestCommand Fixes #4120
1 parent 1180586 commit 9f07887

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

buildscripts/make_dependencies.bat

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,8 @@ if not exist "%CMAKE_NAME%" (
1616
call :installCmake
1717
)
1818
set PATH=%PATH%;%cd%\%CMAKE_NAME%\bin
19-
powershell -command "& { iwr https://github.com/google/protobuf/archive/v%PROTOBUF_VER%.zip -OutFile protobuf.zip }"
19+
@rem GitHub requires TLSv1.2, and for whatever reason our powershell doesn't have it enabled
20+
powershell -command "& { [Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12 ; iwr https://github.com/google/protobuf/archive/v%PROTOBUF_VER%.zip -OutFile protobuf.zip }"
2021
powershell -command "& { Add-Type -AssemblyName System.IO.Compression.FileSystem; [System.IO.Compression.ZipFile]::ExtractToDirectory('protobuf.zip', '.') }"
2122
del protobuf.zip
2223
pushd protobuf-%PROTOBUF_VER%\cmake

0 commit comments

Comments
 (0)