Skip to content

Unset GKE zone/region for zonal/regional clusters #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 8, 2025
Merged

Unset GKE zone/region for zonal/regional clusters #198

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fa4813b
unset location env variables when not required
arjan-bal Aug 26, 2025
cc4d82c
Wrap comments
arjan-bal Aug 26, 2025
ad77fa8
unset at the beginning of the function
arjan-bal Sep 8, 2025
71fe125
Update .kokoro/psm_interop_kokoro_lib.sh
arjan-bal Sep 8, 2025
74b1ab4
set to empty string instead of using unset
arjan-bal Sep 8, 2025
bd6ea8f
Apply suggestion from @sergiitk
sergiitk Sep 8, 2025
6f0f4ac
Apply suggestion from @sergiitk
sergiitk Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .kokoro/psm_interop_kokoro_lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,13 +850,19 @@ psm::tools::log() {
# Globals:
# GKE_CLUSTER_NAME: Set to reflect the cluster name to use
# GKE_CLUSTER_ZONE: Set to reflect the cluster zone to use.
# This variable will be empty for regional clusters.
# GKE_CLUSTER_REGION: Set to reflect the cluster region to use (for regional clusters).
# This variable will be empty for zonal clusters.
# Arguments:
# The cluster identifier
# Outputs:
# Writes the output to stdout, stderr
#######################################
activate_gke_cluster() {
# Reset the variables: activate_gke_cluster may be called multiple times.
GKE_CLUSTER_REGION=""
GKE_CLUSTER_ZONE=""
GKE_CLUSTER_NAME=""
case $1 in
GKE_CLUSTER_PSM_LB)
GKE_CLUSTER_NAME="psm-interop-lb-primary"
Expand Down