fix: Removing Unit.AbsolutePath()

Author: yhakbar

internal/component/unit.go

@@ -10,7 +10,6 @@ import (
 	"github.com/gruntwork-io/terragrunt/internal/tf"
 	"github.com/gruntwork-io/terragrunt/internal/util"
 	"github.com/gruntwork-io/terragrunt/pkg/config"
-	"github.com/gruntwork-io/terragrunt/pkg/log"
 )
 
 const (
@@ -258,19 +257,6 @@ func (u *Unit) String() string {
 	)
 }
 
-// AbsolutePath returns the absolute path of the unit.
-// If path conversion fails, logs the error and returns the original path.
-func (u *Unit) AbsolutePath(l log.Logger) string {
-	absPath, err := filepath.Abs(u.path)
-	if err != nil {
-		l.Errorf("Error converting unit path %s to absolute path: %v", u.path, err)
-
-		return u.path
-	}
-
-	return absPath
-}
-
 // DisplayPath returns the path relative to DiscoveryContext.WorkingDir for display purposes.
 // Falls back to the original path if relative path calculation fails or WorkingDir is empty.
 func (u *Unit) DisplayPath() string {

internal/component/unit_output.go

@@ -4,8 +4,6 @@ import (
 	"fmt"
 	"io"
 	"sync"
-
-	"github.com/gruntwork-io/terragrunt/pkg/log"
 )
 
 // flusher is any writer that supports Flush() error.
@@ -40,7 +38,7 @@ func unitOutputLock(key string) *sync.Mutex {
 
 // FlushOutput flushes buffer data to the given writer for this unit, if the writer supports it.
 // This is safe to call even if u or w is nil.
-func FlushOutput(l log.Logger, u *Unit, w io.Writer) error {
+func FlushOutput(u *Unit, w io.Writer) error {
 	if u == nil || w == nil {
 		return nil
 	}
@@ -52,7 +50,7 @@ func FlushOutput(l log.Logger, u *Unit, w io.Writer) error {
 
 	// Use parent writer's address as lock key to serialize flushes to same parent.
 	// Falls back to unit path for writers without parentWriterProvider.
-	key := u.AbsolutePath(l)
+	key := u.Path()
 	if pwp, ok := w.(parentWriterProvider); ok {
 		key = fmt.Sprintf("%p", pwp.ParentWriter())
 	}

internal/runner/common/unit_runner.go

@@ -54,14 +54,14 @@ func (runner *UnitRunner) runTerragrunt(
 
 	defer func() {
 		// Flush buffered output for this unit, if the writer supports it.
-		if err := component.FlushOutput(l, runner.Unit, opts.Writer); err != nil {
+		if err := component.FlushOutput(runner.Unit, opts.Writer); err != nil {
 			l.Errorf("Error flushing output for unit %s: %v", runner.Unit.Path(), err)
 		}
 	}()
 
 	// Only create report entries if report is not nil
 	if r != nil {
-		unitPath := runner.Unit.AbsolutePath(l)
+		unitPath := runner.Unit.Path()
 		unitPath = util.CleanPath(unitPath)
 
 		// Pass the discovery context fields for worktree scenarios
@@ -93,14 +93,14 @@ func (runner *UnitRunner) runTerragrunt(
 
 	// Store the unit exit code in the global map using the unit path as key.
 	if globalExitCode != nil {
-		unitPath := filepath.Dir(opts.OriginalTerragruntConfigPath)
+		unitPath := runner.Unit.Path()
 		code := unitExitCode.Get(unitPath)
 		globalExitCode.Set(unitPath, code)
 	}
 
 	// End the run with appropriate result (only if report is not nil)
 	if r != nil {
-		unitPath := runner.Unit.AbsolutePath(l)
+		unitPath := runner.Unit.Path()
 		unitPath = util.CleanPath(unitPath)
 
 		if runErr != nil {

internal/runner/runnerpool/runner.go

@@ -364,8 +364,7 @@ func (rnr *Runner) Run(ctx context.Context, l log.Logger, stackOpts *options.Ter
 	if r != nil {
 		for _, u := range rnr.Stack.Units {
 			if u.Excluded() {
-				// Ensure path is absolute for reporting
-				unitPath := u.AbsolutePath(l)
+				unitPath := u.Path()
 
 				// Pass the discovery context fields for worktree scenarios
 				var ensureOpts []report.EndOption
@@ -506,8 +505,7 @@ func (rnr *Runner) Run(ctx context.Context, l log.Logger, stackOpts *options.Ter
 					continue
 				}
 
-				// Ensure path is absolute for reporting
-				unitPath := unit.AbsolutePath(l)
+				unitPath := unit.Path()
 
 				// Pass the discovery context fields for worktree scenarios
 				var ensureOpts []report.EndOption

test/integration_test.go

@@ -428,7 +428,11 @@ func TestDetailedExitCodeChangesPresentAllWithSource(t *testing.T) {
 	ctx := t.Context()
 	ctx = tf.ContextWithDetailedExitCode(ctx, exitCode)
 
-	_, _, err := helpers.RunTerragruntCommandWithOutputWithContext(t, ctx, "terragrunt run --all --non-interactive --working-dir "+rootPath+" -- plan -detailed-exitcode")
+	_, _, err := helpers.RunTerragruntCommandWithOutputWithContext(
+		t,
+		ctx,
+		"terragrunt run --all --non-interactive --working-dir "+rootPath+" -- plan -detailed-exitcode",
+	)
 	require.NoError(t, err)
 	assert.Equal(t, 2, exitCode.GetFinalDetailedExitCode())
 }