Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially incorrect operator in the Positive_charge Function #9

Open
heyerbobby opened this issue Sep 1, 2020 · 1 comment
Open

Comments

@heyerbobby
Copy link

Background
The positive_charge function in the read battery_model.py file appears to constrain Eout when the S < Rmax.

Current Behavior
Currently the battery is exporting more power than it can hold. for example; When S = 100, RMax = 250 and eta = 0.90, Eout currently equals 105

Expected Behavior
the desired output should be as follows; When S = 100, RMax = 250 and eta = 0.90, Eout should equal 95

Possible Solution
In the positive_charge function switch the operator from divide to multiply

@gschivley
Copy link
Owner

Thanks. This is an old project but I’ll take a look to confirm and fix.

Sent with GitHawk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants