Skip to content

Change CommandEventArgs to be based on HandledEventArgs instead of CancelEventArgs #4023

@tig

Description

@tig

Yep. If you do something in an Accepting handler you need to set Cancel to indicate that.

Originally posted by @tig in #4022

I goofed in using CancelEventArgs as "Handled" just makes more sense in most cases.

Related:

Fix is straight forward but will touch a ton of files:

-public class CommandEventArgs : CancelEventArgs
+public class CommandEventArgs : HandledEventArgs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    Status

    ✅ Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions