Skip to content

Test support for windows #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phated opened this issue Dec 28, 2014 · 3 comments
Closed

Test support for windows #3

phated opened this issue Dec 28, 2014 · 3 comments

Comments

@phated
Copy link
Member

phated commented Dec 28, 2014

To get exec to work on windows, something special needs to be done. Not sure what it is. Also need to update current tests.

@heikki
Copy link
Contributor

heikki commented Dec 28, 2014

Hey, do you mean these errors?

screen shot 2014-12-28 at 14 25 08

This is the closest explanation I could find: requirejs/r.js#369 (comment)

Exec tries to run index.js with Windows Script Host.

@heikki
Copy link
Contributor

heikki commented Dec 28, 2014

Above thing can be fixed by adding node to exec commands.

child.exec('node ' + __dirname + '/../index.js --tasks --cwd ./test', function(err, stdout) {

After that there's issues with line endings and stdout truncating.

screen shot 2014-12-28 at 18 43 34

Some projects, for example grunt, use node-exit to fix stdout problem. I'll have to dig further to see what actually needs that fix.

@heikki heikki mentioned this issue Dec 28, 2014
@phated
Copy link
Member Author

phated commented Dec 28, 2014

Fixed by #4

@phated phated closed this as completed Dec 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants