Skip to content

Commit 8a6becc

Browse files
committed
Update: Refactor and reword tests
1 parent 193d1d8 commit 8a6becc

27 files changed

+2212
-2434
lines changed

.travis.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ node_js:
77
- '0.10'
88
before_script:
99
- find test -type d -exec chmod g+s {} \;
10-
- sudo chown root test/not-owned/
11-
- sudo chown root test/not-owned/not-owned.txt
10+
- sudo chown root test/fixtures/not-owned/
11+
- sudo chown root test/fixtures/not-owned/not-owned.txt
1212
after_script:
1313
- npm run coveralls

lib/prepare-write.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,9 @@ function prepareWrite(outFolder, file, opt, callback) {
4444
file.stat.mode = options.mode;
4545
file.flag = options.flag;
4646
file.cwd = cwd;
47-
file.base = basePath;
47+
// Ensure the base always ends with a separator
48+
// TODO: add a test for this
49+
file.base = path.normalize(basePath + path.sep);
4850
file.path = writePath;
4951

5052
fo.mkdirp(writeFolder, options.dirMode, onMkdirp);

package.json

+2-8
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,17 @@
3131
"vinyl": "^1.0.0"
3232
},
3333
"devDependencies": {
34-
"buffer-equal": "^0.0.1",
35-
"default-resolution": "^1.0.1",
3634
"del": "^2.2.0",
3735
"eslint": "^1.10.3",
3836
"eslint-config-gulp": "^2.0.0",
3937
"expect": "^1.14.0",
40-
"from2": "^2.1.1",
4138
"github-changes": "^1.0.1",
4239
"istanbul": "^0.3.0",
4340
"istanbul-coveralls": "^1.0.1",
4441
"jscs": "^2.4.0",
4542
"jscs-preset-gulp": "^1.0.0",
46-
"mocha": "^2.0.0",
47-
"mocha-lcov-reporter": "^1.0.0",
48-
"rimraf": "^2.2.5",
49-
"should": "^7.0.0",
50-
"sinon": "^1.10.3"
43+
"mississippi": "^1.2.0",
44+
"mocha": "^2.0.0"
5145
},
5246
"scripts": {
5347
"lint": "eslint . && jscs index.js lib/ test/",

0 commit comments

Comments
 (0)