Build: Check mode of not-owned.txt & avoid repeated notices (#232)

Author: erikkemperman

.travis.yml

@@ -8,7 +8,7 @@ node_js:
   - '0.10'
 before_script:
   - find test -type d -exec chmod g+s {} \;
-  - sudo chown root test/fixtures/not-owned/
   - sudo chown root test/fixtures/not-owned/not-owned.txt
+  - sudo chmod 666 test/fixtures/not-owned/not-owned.txt
 after_script:
   - npm run coveralls

test/not-owned.js

@@ -23,16 +23,38 @@ var clean = cleanup();
 
 describe('.dest() on not owned files', function() {
 
-  var dirStats = fs.statSync(notOwnedBase);
   var fileStats = fs.statSync(notOwnedPath);
 
   beforeEach(clean);
   afterEach(clean);
 
+  var seenActions = false;
+
+  function needsAction() {
+    var problems = [];
+    var actions = [];
+    if (fileStats.uid !== 0) {
+      problems.push('Test files not owned by root.');
+      actions.push('  sudo chown root ' + notOwnedPath);
+    }
+    if ((fileStats.mode & parseInt('022', 8)) !== parseInt('022', 8)) {
+      problems.push('Test files not readable/writable by non-owners.');
+      actions.push('  sudo chmod 666 ' + notOwnedPath);
+    }
+    if (actions.length > 0) {
+      if (!seenActions) {
+        console.log(problems.join('\n'));
+        console.log('Please run the following commands and try again:');
+        console.log(actions.join('\n'));
+        seenActions = true;
+      }
+      return true;
+    }
+    return false;
+  }
+
   it('does not error if mtime is different', function(done) {
-    if (dirStats.uid !== 0 || fileStats.uid !== 0) {
-      console.log('Test files not owned by root.');
-      console.log('Please chown ' + notOwnedBase + ' and ' + notOwnedPath + ' and try again.');
+    if (needsAction()) {
       this.skip();
       return;
     }
@@ -62,9 +84,7 @@ describe('.dest() on not owned files', function() {
   });
 
   it('does not error if mode is different', function(done) {
-    if (dirStats.uid !== 0 || fileStats.uid !== 0) {
-      console.log('Test files not owned by root.');
-      console.log('Please chown ' + notOwnedBase + ' and ' + notOwnedPath + ' and try again.');
+    if (needsAction()) {
       this.skip();
       return;
     }