diff --git a/packages/yoga/src/Snackbar/native/Snackbar.jsx b/packages/yoga/src/Snackbar/native/Snackbar.jsx index 9043c68985..d82ade04d6 100644 --- a/packages/yoga/src/Snackbar/native/Snackbar.jsx +++ b/packages/yoga/src/Snackbar/native/Snackbar.jsx @@ -64,7 +64,6 @@ const Snackbar = forwardRef((props, ref) => { onSnackbarClose, duration, bottomOffset, - dataTestId, ...rest } = props; const wrapperRef = useRef(); @@ -150,7 +149,6 @@ const Snackbar = forwardRef((props, ref) => { @@ -203,8 +201,6 @@ Snackbar.propTypes = { duration: oneOf(['fast', 'default', 'slow', 'indefinite']), /** Add extra margin to Snackbar. Can be useful for SafeAreaView or button cases. */ bottomOffset: number, - /* A unique identifier for the Snackbar component, used for testing purposes with tools like Jest and Testing Library. */ - dataTestId: string, }; Snackbar.defaultProps = { @@ -216,7 +212,6 @@ Snackbar.defaultProps = { onSnackbarClose: undefined, duration: 'default', bottomOffset: 0, - dataTestId: 'snackbar', }; export default Snackbar; diff --git a/packages/yoga/src/Snackbar/native/Snackbar.test.jsx b/packages/yoga/src/Snackbar/native/Snackbar.test.jsx index ee56a37525..3629ccadcc 100644 --- a/packages/yoga/src/Snackbar/native/Snackbar.test.jsx +++ b/packages/yoga/src/Snackbar/native/Snackbar.test.jsx @@ -42,7 +42,7 @@ describe('', () => { }); it('should render with custom dataTestId', () => { - const { getByTestId } = render(); + const { getByTestId } = render(); fireEvent.press(getByTestId('custom-snackbar')); diff --git a/packages/yoga/src/Snackbar/native/__snapshots__/Snackbar.test.jsx.snap b/packages/yoga/src/Snackbar/native/__snapshots__/Snackbar.test.jsx.snap index 2c0cc19972..9207548079 100644 --- a/packages/yoga/src/Snackbar/native/__snapshots__/Snackbar.test.jsx.snap +++ b/packages/yoga/src/Snackbar/native/__snapshots__/Snackbar.test.jsx.snap @@ -132,7 +132,6 @@ exports[` should match snapshot when have a long text 1`] = ` }, ] } - testID="snackbar" variant="success" > should match snapshot when have a variant informative or a }, ] } - testID="snackbar" variant="informative" > should match snapshot when have an icon and action 1`] = ` }, ] } - testID="snackbar" variant="success" > should match snapshot when snackbar is default 1`] = ` }, ] } - testID="snackbar" variant="success" > {!hideIcon && ( @@ -162,7 +160,6 @@ const Snackbar = React.forwardRef( alignItems="center" mr="small" role="img" - data-testid="img" aria-hidden > ', () => { open message="Make wellbeing universal" onClose={jest.fn()} - dataTestId="custom-snackbar" + data-testid="custom-snackbar" /> , ); @@ -34,12 +34,20 @@ describe('', () => { it('should render a minimal snackbar', () => { render( - + , ); screen.getByRole('alert'); - screen.getByTestId('img'); + screen.getByTestId('custom-snackbar'); + expect( + screen.getByTestId('custom-snackbar').querySelector('[role="img"]'), + ).toBeTruthy(); screen.getByLabelText('success'); screen.getByText('Make wellbeing universal'); }); diff --git a/packages/yoga/src/Snackbar/web/__snapshots__/Snackbar.test.jsx.snap b/packages/yoga/src/Snackbar/web/__snapshots__/Snackbar.test.jsx.snap index aa3d47c2ec..1092c35702 100644 --- a/packages/yoga/src/Snackbar/web/__snapshots__/Snackbar.test.jsx.snap +++ b/packages/yoga/src/Snackbar/web/__snapshots__/Snackbar.test.jsx.snap @@ -122,13 +122,11 @@ exports[` should match snapshot 1`] = `