From d6245414dbbec056cf3f3c309d30c5d35119ed92 Mon Sep 17 00:00:00 2001 From: Zurabi Kobakhidze - External Date: Fri, 5 Jan 2024 13:48:42 +0400 Subject: [PATCH 1/2] feat: fix close button always hidden issue --- Sources/SharkCardScan/SharkCardScanViewController.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sources/SharkCardScan/SharkCardScanViewController.swift b/Sources/SharkCardScan/SharkCardScanViewController.swift index 3d73f43..9306008 100644 --- a/Sources/SharkCardScan/SharkCardScanViewController.swift +++ b/Sources/SharkCardScan/SharkCardScanViewController.swift @@ -15,7 +15,7 @@ public class SharkCardScanViewController: UIViewController { private var styling: CardScanStyling private lazy var closeButton = UIButton().with { - $0.setBackgroundImage(UIImage(named: "rounded close"), for: .normal) + $0.setBackgroundImage(UIImage(named: "rounded close", in: Bundle.module, compatibleWith: nil), for: .normal) $0.accessibilityLabel = String(describing: SharkCardScanViewController.self) + "." + "CloseButton" } From 9828b599f3ff6e647f737da559598f6c303dd416 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mattia=20Cantal=C3=B9?= Date: Thu, 18 Jan 2024 15:02:58 +0100 Subject: [PATCH 2/2] feat(privacy): adding privacy manifest --- Package.swift | 11 +++----- Sources/Resources/PrivacyInfo.xcprivacy | 35 +++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 7 deletions(-) create mode 100644 Sources/Resources/PrivacyInfo.xcprivacy diff --git a/Package.swift b/Package.swift index fdee614..bc83bd3 100644 --- a/Package.swift +++ b/Package.swift @@ -7,25 +7,22 @@ let package = Package( name: "SharkCardScan", platforms: [ .iOS(.v13)], products: [ - // Products define the executables and libraries a package produces, and make them visible to other packages. .library( name: "SharkCardScan", targets: ["SharkCardScan"]), ], dependencies: [ - // Dependencies declare other packages that this package depends on. - // .package(url: /* package url */, from: "1.0.0"), dependencies: [ - .package( + .package( name: "SharkUtils", url: "https://github.com/gymshark/ios-shark-utils.git", .exact("1.0.5")), ], targets: [ - // Targets are the basic building blocks of a package. A target can define a module or a test suite. - // Targets can depend on other targets in this package, and on products in packages this package depends on. .target( name: "SharkCardScan", - dependencies: ["SharkUtils"]), + dependencies: ["SharkUtils"], + path: "Sources", + resources: [.copy("Resources/PrivacyInfo.xcprivacy")]), .testTarget( name: "SharkCardScanTests", dependencies: ["SharkCardScan"]), diff --git a/Sources/Resources/PrivacyInfo.xcprivacy b/Sources/Resources/PrivacyInfo.xcprivacy new file mode 100644 index 0000000..c812676 --- /dev/null +++ b/Sources/Resources/PrivacyInfo.xcprivacy @@ -0,0 +1,35 @@ + + + + + NSPrivacyCollectedDataTypes + + + NSPrivacyCollectedDataType + NSPrivacyCollectedDataTypeName + NSPrivacyCollectedDataTypeLinked + + NSPrivacyCollectedDataTypeTracking + + NSPrivacyCollectedDataTypePurposes + + NSPrivacyCollectedDataTypePurposeAppFunctionality + + + + NSPrivacyCollectedDataType + NSPrivacyCollectedDataTypePaymentInfo + NSPrivacyCollectedDataTypeLinked + + NSPrivacyCollectedDataTypeTracking + + NSPrivacyCollectedDataTypePurposes + + NSPrivacyCollectedDataTypePurposeAppFunctionality + + + + NSPrivacyTracking + + +