Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For http API calls, consider returning an error rather than redirecting to https #530

Open
anyonecancode opened this issue May 28, 2024 · 2 comments
Labels
Infra Team Requires review / feedback / etc. with infra team

Comments

@anyonecancode
Copy link

What would you like to discuss with us or let us know?

I was reading https://jviide.iki.fi/http-redirects, which I think makes a good argument for having http calls to an API endpoint return an error rather than redirect to https. tl;dr -- for api endpoints, these are generally not meant for browsers, and it becomes easy to accidentally leak secrets as servers will call the plain text http version first.

I saw that mastodon was listed among the servers tried that redirects rather than errors, and confirmed that hachyderm.io does too.

@Preskton
Copy link
Sponsor Contributor

Howdy, we are looking in to if we can apply a blanket policy on the /api route to follow the suggested behavior. Ideally, masto would implement this in the upstream codebase as well so that it's more "permanent".

@quintessence quintessence added the Infra Team Requires review / feedback / etc. with infra team label Jun 30, 2024
@dmah42
Copy link
Sponsor Contributor

dmah42 commented Aug 23, 2024

have we filed an upstream issue against mastodon for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infra Team Requires review / feedback / etc. with infra team
Projects
None yet
Development

No branches or pull requests

4 participants