Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract pages level elements from Search & refactor to use hooks #851

Closed
logan-r opened this issue Jul 26, 2020 · 0 comments · May be fixed by #854
Closed

Extract pages level elements from Search & refactor to use hooks #851

logan-r opened this issue Jul 26, 2020 · 0 comments · May be fixed by #854
Assignees
@pengyk
Labels
P1 Medium priority refactor Change code around without affecting presentation

Comments

@logan-r
Copy link
Member

logan-r commented Jul 26, 2020

  1. features/search/Search should be refactored to use hooks
  2. All page level styling, -level elements, background images, etc. should be moved to nest this component in their respective page(s)
  3. Other components in features/search/ should then be refactored to use hooks
@logan-r logan-r added P1 Medium priority refactor Change code around without affecting presentation labels Jul 26, 2020
@pengyk pengyk mentioned this issue Aug 1, 2020
Open
10 tasks
@pengyk pengyk closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pengyk pengyk

Labels
P1 Medium priority refactor Change code around without affecting presentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: extract page elements and use hooks for search hackmcgill/dashboard
2 participants
@logan-r @pengyk