Revert "Added hackboard role support"

This reverts commit 481d303.

Author: MikaVohl

constants/general.constant.js

@@ -72,7 +72,6 @@ const SAMPLE_DIET_RESTRICTIONS = [
 const HACKER = "Hacker";
 const VOLUNTEER = "Volunteer";
 const STAFF = "Staff";
-const HACKBOARD = "Hackboard";
 const SPONSOR = "Sponsor";
 
 const SPONSOR_T1 = "SponsorT1";
@@ -110,9 +109,8 @@ POST_ROLES[SPONSOR_T4] = "postSponsor";
 POST_ROLES[SPONSOR_T5] = "postSponsor";
 POST_ROLES[VOLUNTEER] = "postVolunteer";
 POST_ROLES[STAFF] = "postStaff";
-POST_ROLES[HACKBOARD] = "Hackboard";
 
-const USER_TYPES = [HACKER, VOLUNTEER, STAFF, HACKBOARD, SPONSOR];
+const USER_TYPES = [HACKER, VOLUNTEER, STAFF, SPONSOR];
 const SPONSOR_TIERS = [
     SPONSOR_T1,
     SPONSOR_T2,
@@ -124,7 +122,6 @@ const EXTENDED_USER_TYPES = [
     HACKER,
     VOLUNTEER,
     STAFF,
-    HACKBOARD,
     SPONSOR_T1,
     SPONSOR_T2,
     SPONSOR_T3,
@@ -171,9 +168,6 @@ CREATE_ACC_EMAIL_SUBJECTS[
 CREATE_ACC_EMAIL_SUBJECTS[
     STAFF
 ] = `You've been invited to create a staff account for ${HACKATHON_NAME}`;
-CREATE_ACC_EMAIL_SUBJECTS[
-    HACKBOARD
-] = `You've been invited to create a hackboard account for ${HACKATHON_NAME}`;
 
 const CACHE_TIMEOUT_STATS = 5 * 60 * 1000;
 const CACHE_KEY_STATS = "hackerStats";
@@ -217,7 +211,6 @@ module.exports = {
     SPONSOR: SPONSOR,
     VOLUNTEER: VOLUNTEER,
     STAFF: STAFF,
-    HACKBOARD: HACKBOARD,
     SPONSOR_T1: SPONSOR_T1,
     SPONSOR_T2: SPONSOR_T2,
     SPONSOR_T3: SPONSOR_T3,

constants/role.constant.js

@@ -20,31 +20,12 @@ const accountRole = {
     ]
 };
 
-const hackboardRestrictedRoutes = [ // hackboard permissions is all staff routes minus these routes
-    Constants.Routes.hackerRoutes.postAnySendWeekOfEmail,
-    Constants.Routes.hackerRoutes.postSelfSendWeekOfEmail,
-    Constants.Routes.hackerRoutes.postAnySendDayOfEmail,
-    Constants.Routes.hackerRoutes.postSelfSendDayOfEmail,
-    Constants.Routes.hackerRoutes.patchAcceptHackerById,
-    Constants.Routes.hackerRoutes.patchAcceptHackerByEmail,
-    Constants.Routes.hackerRoutes.patchAcceptHackerByArrayOfIds,
-    Constants.Routes.hackerRoutes.patchAnyStatusById,
-    Constants.Routes.settingsRoutes.getSettings,
-    Constants.Routes.settingsRoutes.patchSettings
-];
-
 const adminRole = {
     _id: mongoose.Types.ObjectId.createFromTime(1),
     name: Constants.General.STAFF,
     routes: Constants.Routes.listAllRoutes()
 };
 
-const hackboardRole = {
-    _id: mongoose.Types.ObjectId.createFromTime(9),
-    name: "Hackboard",
-    routes: createHackboardRoutes()
-};
-
 const hackerRole = {
     _id: mongoose.Types.ObjectId.createFromTime(2),
     name: Constants.General.HACKER,
@@ -162,15 +143,6 @@ const singularRoles = createAllSingularRoles();
 const allRolesObject = createAllRoles();
 const allRolesArray = Object.values(allRolesObject);
 
-function createHackboardRoutes() {
-    const restrictedRouteIds = new Set(
-        hackboardRestrictedRoutes.map((route) => route._id.toString())
-    );
-    return Constants.Routes.listAllRoutes().filter((route) => {
-        return !restrictedRouteIds.has(route._id.toString());
-    });
-}
-
 /**
  * Creates all the roles that are of a specific uri and request type
  * @return {Role[]}
@@ -213,7 +185,6 @@ function createAllRoles() {
     let allRolesObject = {
         accountRole: accountRole,
         adminRole: adminRole,
-        hackboardRole: hackboardRole,
         hackerRole: hackerRole,
         volunteerRole: volunteerRole,
         sponsorT1Role: sponsorT1Role,
@@ -237,7 +208,6 @@ function createAllRoles() {
 module.exports = {
     accountRole: accountRole,
     adminRole: adminRole,
-    hackboardRole: hackboardRole,
     hackerRole: hackerRole,
     volunteerRole: volunteerRole,
     sponsorT1Role: sponsorT1Role,

middlewares/auth.middleware.js

@@ -477,11 +477,6 @@ async function addCreationRoleBindings(req, res, next) {
             req.body.account.id,
             Constants.Role.adminRole.name
         );
-    } else if (req.body.account.accountType === Constants.General.HACKBOARD) {
-        await Services.RoleBinding.createRoleBindingByRoleName(
-            req.body.account.id,
-            Constants.Role.hackboardRole.name
-        );
     } else {
         // Get the default role for the account type given
         const roleName =

services/accountConfirmation.service.js

@@ -172,8 +172,6 @@ function generateAccountInvitationEmail(address, receiverEmail, type, token) {
         emailSubject = Constants.CREATE_ACC_EMAIL_SUBJECTS[Constants.SPONSOR];
     } else if (type === Constants.STAFF) {
         emailSubject = Constants.CREATE_ACC_EMAIL_SUBJECTS[Constants.STAFF];
-    } else if (type === Constants.HACKBOARD) {
-        emailSubject = Constants.CREATE_ACC_EMAIL_SUBJECTS[Constants.HACKBOARD];
     }
     const handlebarPath = path.join(
         __dirname,

tests/util/roleBinding.test.util.js

@@ -25,9 +25,6 @@ function createRoleBinding(accountId, accountType = null, specificRoles = []) {
         case Constants.General.STAFF:
             roleBinding.roles.push(Constants.Role.adminRole);
             break;
-        case Constants.General.HACKBOARD:
-            roleBinding.roles.push(Constants.Role.hackboardRole);
-            break;
         case Constants.General.SPONSOR_T1:
             roleBinding.roles.push(Constants.Role.sponsorT1Role);
             break;