[query] move checkRVDKeys from HailContext to RVD$

Author: ehigham

hail/hail/src/is/hail/HailContext.scala

@@ -162,8 +162,6 @@ class HailContext private (
 ) {
   def stop(): Unit = HailContext.stop()
 
-  var checkRVDKeys: Boolean = false
-
   def version: String = is.hail.HAIL_PRETTY_VERSION
 
   private[this] def fileAndLineCounts(

hail/hail/src/is/hail/rvd/RVD.scala

@@ -1061,6 +1061,9 @@ class RVD(
 }
 
 object RVD {
+
+  var CheckRvdKeyOrderingForTesting: Boolean = false
+
   def empty(ctx: ExecuteContext, typ: RVDType): RVD =
     RVD.empty(ctx.stateManager, typ)
 
@@ -1313,15 +1316,10 @@ object RVD {
     RVDPartitioner.fromKeySamples(ctx, typ, min, max, samples, nPartitions, partitionKey)
   }
 
-  def apply(
-    typ: RVDType,
-    partitioner: RVDPartitioner,
-    crdd: ContextRDD[Long],
-  ): RVD =
-    if (!HailContext.get.checkRVDKeys)
-      new RVD(typ, partitioner, crdd)
-    else
-      new RVD(typ, partitioner, crdd).checkKeyOrdering()
+  def apply(typ: RVDType, partitioner: RVDPartitioner, crdd: ContextRDD[Long]): RVD = {
+    val rvd = new RVD(typ, partitioner, crdd)
+    if (CheckRvdKeyOrderingForTesting) rvd.checkKeyOrdering() else rvd
+  }
 
   def unify(execCtx: ExecuteContext, rvds: Seq[RVD]): Seq[RVD] = {
     if (rvds.length == 1 || rvds.forall(_.rowPType == rvds.head.rowPType))

hail/hail/test/src/is/hail/HailSuite.scala

@@ -11,6 +11,7 @@ import is.hail.expr.ir.defs.{
 }
 import is.hail.expr.ir.lowering.IrMetadata
 import is.hail.io.fs.{FS, HadoopFS}
+import is.hail.rvd.RVD
 import is.hail.types.virtual._
 import is.hail.utils._
 import is.hail.variant.ReferenceGenome
@@ -29,6 +30,8 @@ import org.testng.ITestContext
 import org.testng.annotations.{AfterClass, AfterSuite, BeforeClass, BeforeSuite}
 
 object HailSuite {
+  RVD.CheckRvdKeyOrderingForTesting = true
+
   val theHailClassLoader: HailClassLoader =
     new HailClassLoader(getClass.getClassLoader)
 
@@ -67,7 +70,6 @@ class HailSuite extends TestNGSuite with TestUtils {
       skipLoggingConfiguration = true,
     )
     HailSuite.hc_ = HailContext(backend)
-    HailSuite.hc_.checkRVDKeys = true
   }
 
   @BeforeClass