Skip to content

Commit ef0a16c

Browse files
authored
[batch] fix idempotent create update (#15171)
## Change Description Fixed the order of return values in the `update` function in `front_end.py`. The function was returning `(update_id, start_job_id, start_job_group_id)` but the correct order should be `(update_id, start_job_group_id, start_job_id)`. ## Security Assessment This change has low impact the Hail Batch instance as deployed by Broad Institute in GCP.
1 parent 15e459b commit ef0a16c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

batch/batch/front_end/front_end.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1866,7 +1866,7 @@ async def update(tx: Transaction):
18661866
)
18671867

18681868
if record:
1869-
return (record['update_id'], record['start_job_id'], record['start_job_group_id'])
1869+
return (record['update_id'], record['start_job_group_id'], record['start_job_id'])
18701870

18711871
# We use FOR UPDATE so that we serialize batch update insertions
18721872
# This is necessary to reserve job id and job group id ranges.

0 commit comments

Comments
 (0)