Skip to content
This repository has been archived by the owner on Nov 21, 2024. It is now read-only.

chore: add go vet tools #111

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore: add go vet tools #111

wants to merge 6 commits into from

Conversation

shiron-dev
Copy link
Contributor

@shiron-dev shiron-dev commented Oct 24, 2024 •
edited by github-actions bot
Loading

close #110
close #35
close #102

--- commit logs ---

  • chore: add go vet tools
  • chore: config linter
  • ci: ref xcとciを共通化 #35
  • ci: fix build ci
  • ci: rm go vet
  • refactor(go): Fix lint errors partially

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 24, 2024 •
edited
Loading

Test coverage

✅ All tests passed successfully.

Status Package Time Coverage
? github.com/halcyon-org/kizuna [no test files]
github.com/halcyon-org/kizuna/cmd/kizuna 0.0%
github.com/halcyon-org/kizuna/cmd/kizuna-cli 0.0%
? github.com/halcyon-org/kizuna/ent [no test files]
github.com/halcyon-org/kizuna/cmd/migration 0.0%
github.com/halcyon-org/kizuna/ent/schema 0.0%
github.com/halcyon-org/kizuna/ent/schema/pulid 0.0%
github.com/halcyon-org/kizuna/gen/belifeline/models/v1 0.0%
github.com/halcyon-org/kizuna/gen/belifeline/v1 0.0%
github.com/halcyon-org/kizuna/gen/belifeline/v1/mainv1connect 0.0%
github.com/halcyon-org/kizuna/gen/ent/adminuser 0.0%
github.com/halcyon-org/kizuna/gen/ent/clientinformation 0.0%
github.com/halcyon-org/kizuna/gen/ent 0.0%
github.com/halcyon-org/kizuna/gen/ent/hook 0.0%
github.com/halcyon-org/kizuna/gen/ent/externalinformation 0.0%
? github.com/halcyon-org/kizuna/gen/ent/predicate [no test files]
? github.com/halcyon-org/kizuna/gen/ent/runtime [no test files]
github.com/halcyon-org/kizuna/gen/ent/koyodata 0.0%
github.com/halcyon-org/kizuna/gen/ent/enttest 0.0%
github.com/halcyon-org/kizuna/gen/ent/koyoinformation 0.0%
github.com/halcyon-org/kizuna/internal/adapter/interceptor 0.0%
github.com/halcyon-org/kizuna/internal/adapter/controller 0.0%
github.com/halcyon-org/kizuna/internal/adapter/api 0.0%
github.com/halcyon-org/kizuna/internal/adapter/repository/config 0.0%
github.com/halcyon-org/kizuna/gen/ent/migrate 0.0%
github.com/halcyon-org/kizuna/internal/di 0.0%
github.com/halcyon-org/kizuna/internal/domain/domain 0.0%
github.com/halcyon-org/kizuna/internal/infrastructure/ent 0.0%
github.com/halcyon-org/kizuna/internal/adapter/repository/ent 0.0%
github.com/halcyon-org/kizuna/internal/usecase 0.0%
github.com/halcyon-org/kizuna/internal/util 0.0%

@shiron-dev shiron-dev marked this pull request as draft October 25, 2024 01:35
@6ouma
Copy link
Contributor

6ouma commented Oct 25, 2024

残りはおよそ以下のwarningのみ

  • depguard: importしていいパッケージを指定する？
  • ireturn: interfaceのreturn
  • エラーのラップ
  • structのfieldが全て埋まってない

@6ouma 6ouma force-pushed the ci/#110 branch 3 times, most recently from 0609b6c to 84a7cc1 Compare October 25, 2024 08:45
@6ouma 6ouma force-pushed the ci/#110 branch 2 times, most recently from 06d6299 to 3fc75ce Compare October 25, 2024 09:03
@6ouma
refactor(go): Fix lint errors partially
c55fce0 
Make this project more sustainable.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go vetにドライバーを追加 style: Api to API xcとciを共通化
2 participants
@shiron-dev @6ouma