Changed: eslint configuration + necessary changes in code. (#137)

Author: swistach

.eslintrc

@@ -0,0 +1,92 @@
+module.exports = {
+  "extends": "airbnb-base",
+  "parser": "babel-eslint",
+  "env": {
+    "browser": true,
+    "commonjs": true,
+    "jasmine": true,
+    "jest": true,
+    "es6": true,
+  },
+  "rules": {
+    "arrow-parens": [
+      "error",
+      "as-needed",
+      { "requireForBlockBody": true }
+    ],
+    "class-methods-use-this": "off",
+    "comma-dangle": "off",
+    "consistent-return": "off",
+    "func-names": "off",
+    "import/extensions": "off",
+    "import/no-extraneous-dependencies": "off",
+    "import/no-unresolved": [
+      "error",
+      { "ignore": ["handsontable", "walkontable"] }
+    ],
+    "indent": [
+      "error",
+      2,
+      {
+        "SwitchCase": 1,
+        "FunctionDeclaration": { "parameters": "first" },
+        "FunctionExpression": { "parameters": "first" }
+      }
+    ],
+    "max-len": [
+      "error",
+      {
+        "code": 170,
+        "ignoreComments": true
+      }
+    ],
+    "newline-per-chained-call": "off",
+    "no-constant-condition": [
+      "error",
+      { "checkLoops": false }
+    ],
+    "no-eq-null": "error",
+    "no-mixed-operators": [
+      "error",
+      { "groups": [["+", "-", "*", "/", "%", "**"]] }
+    ],
+    "no-multiple-empty-lines": [
+      "error",
+      { "max": 1 }
+    ],
+    "no-param-reassign": "off",
+    "no-plusplus": [
+      "error",
+      { "allowForLoopAfterthoughts": true }
+    ],
+    "no-restricted-globals": [
+      "error",
+      "Handsontable",
+      {
+        "name": "console",
+        "message": "Using the `console` object is not allowed within Handsontable. Please use one of the helpers from the `console.js` file instead."
+      }
+    ],
+    "no-underscore-dangle": "off",
+    "no-use-before-define": [
+      "error",
+      {
+        "functions": false,
+        "classes": false
+      }
+    ],
+    "no-void": "off",
+    "padded-blocks": "off",
+    "quotes": [ "error", "single" ],
+    "space-before-function-paren": ["error", "never"],
+  },
+  "overrides": [
+    {
+      "files": ["test/**", "src/3rdparty/walkontable/test/**", "*.unit.js", "*.e2e.js", "src/plugins/**/test/helpers/**"],
+      "rules": {
+        "no-restricted-globals": "off",
+        "no-undef": "off",
+      }
+    }
+  ],
+}

.eslintrc.js

@@ -38,7 +38,6 @@ describe('ColumnSummarySpec', () => {
       tempEndpoint = null;
     }
 
-
     return endpoints;
   };
 

src/plugins/columnSummary/test/columnSummary.e2e.js

@@ -753,7 +753,6 @@ class Filters extends BasePlugin {
     }
   }
 
-
   /**
    * Removes specific rows from `hiddenRows` cache for particular column.
    *

src/plugins/filters/filters.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 describe('Filters', () => {
   const id = 'testContainer';
 

src/plugins/filters/test/filters.e2e.js

@@ -971,7 +971,6 @@ describe('Filters UI', () => {
         expect(checkedArray).toEqual([false, true, true]);
       });
 
-
       it('should show proper number of values after refreshing cache ' +
         '(should remove the value from component), case nr 2 (changing value to match filtered value)', (done) => {
         handsontable({

src/plugins/filters/test/filtersUI.e2e.js

@@ -71,7 +71,6 @@ describe('Formulas general', () => {
     expect(hot.getDataAtCell(0, 1)).toBe('=');
   });
 
-
   it('should calculate table with semicolon as separator of formula arguments', () => {
     const data = getDataSimpleExampleFormulas();
 

src/plugins/formulas/test/formulas.e2e.js

@@ -45,7 +45,6 @@ describe('DateCalculator', () => {
     });
   });
 
-
   describe('the `dateToColumn` method', () => {
     it('should return a column for a provided date (in string or Date format), when `allowSplitWeeks` is set to true (default)', () => {
       const plugin = new DateCalculator({
@@ -94,7 +93,6 @@ describe('DateCalculator', () => {
         year: 2017
       });
 
-
       // mock the day cache creation from the actual plugin:
       plugin.daysInColumns[2017] = stdCache;
 
@@ -107,7 +105,6 @@ describe('DateCalculator', () => {
         year: 2018
       });
 
-
       // mock the day cache creation from the actual plugin:
       plugin.daysInColumns[2017] = stdCache;
 

src/plugins/ganttChart/test/dateCalculator.unit.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 describe('GanttChart', () => {
   const id = 'testContainer';
 
@@ -132,7 +133,6 @@ describe('GanttChart', () => {
         }
       });
 
-
       expect(hot.getCellMeta(0, 1).className.indexOf('rangeBar')).toBeGreaterThan(-1);
       expect(hot.getCellMeta(0, 2).className.indexOf('rangeBar')).toBeGreaterThan(-1);
       expect(hot.getCellMeta(0, 3).className.indexOf('rangeBar')).toBeGreaterThan(-1);

src/plugins/ganttChart/test/ganttChart.e2e.js

@@ -88,7 +88,6 @@ class HiddenColumns extends BasePlugin {
     this.lastSelectedColumn = -1;
   }
 
-
   /**
    * Checks if the plugin is enabled in the handsontable settings. This method is executed in {@link Hooks#beforeInit}
    * hook and if it returns `true` than the {@link HiddenColumns#enablePlugin} method is called.
@@ -529,7 +528,6 @@ class HiddenColumns extends BasePlugin {
     );
   }
 
-
   /**
    * `onAfterCreateCol` hook callback.
    *
@@ -549,7 +547,6 @@ class HiddenColumns extends BasePlugin {
     this.hiddenColumns = tempHidden;
   }
 
-
   /**
    * `onAfterRemoveCol` hook callback.
    *