fixup! refactor: 💡 Refactor select query generation

Author: ZedLi

addons/core/tests/integration/components/dropdown/index-test.js

@@ -127,7 +127,7 @@ module('Integration | Component | dropdown/index', function (hooks) {
     assert.true(result);
   });
 
-  test('it only renders a max of 500 items but allows searching on all items', async function (assert) {
+  test('it only renders a max of 250 items but allows searching on all items', async function (assert) {
     this.set('checkedItems', []);
     this.set(
       'itemOptions',
@@ -145,7 +145,7 @@ module('Integration | Component | dropdown/index', function (hooks) {
 
     await click(TOGGLE_DROPDOWN_SELECTOR);
 
-    assert.dom(ITEM_SELECTOR).exists({ count: 500 });
+    assert.dom(ITEM_SELECTOR).exists({ count: 250 });
 
     // Random number between 500 and 599 to search
     await fillIn(SEARCH_INPUT_SELECTOR, '591');

ui/admin/tests/acceptance/session-recordings/list-test.js

@@ -232,13 +232,14 @@ module('Acceptance | session-recordings | list', function (hooks) {
     assert.dom(commonSelectors.TABLE_ROWS).isVisible({ count: 2 });
 
     await click(commonSelectors.FILTER_DROPDOWN('user'));
+    await waitFor(commonSelectors.FILTER_DROPDOWN_ITEM(instances.user.id));
     await click(commonSelectors.FILTER_DROPDOWN_ITEM(instances.user.id));
     await click(commonSelectors.FILTER_DROPDOWN_ITEM_APPLY_BTN('user'));
 
     assert.dom(commonSelectors.TABLE_ROWS).isVisible({ count: 1 });
   });
 
-  test('user can filter session recordings by scope', async function (assert) {
+  test('user can filter session recordings by target', async function (assert) {
     setRunOptions({
       rules: {
         'color-contrast': {
@@ -255,13 +256,14 @@ module('Acceptance | session-recordings | list', function (hooks) {
     assert.dom(commonSelectors.TABLE_ROWS).isVisible({ count: 2 });
 
     await click(commonSelectors.FILTER_DROPDOWN('target'));
+    await waitFor(commonSelectors.FILTER_DROPDOWN_ITEM(instances.target.id));
     await click(commonSelectors.FILTER_DROPDOWN_ITEM(instances.target.id));
     await click(commonSelectors.FILTER_DROPDOWN_ITEM_APPLY_BTN('target'));
 
     assert.dom(commonSelectors.TABLE_ROWS).isVisible({ count: 1 });
   });
 
-  test('user can filter session recordings by target', async function (assert) {
+  test('user can filter session recordings by scope', async function (assert) {
     setRunOptions({
       rules: {
         'color-contrast': {
@@ -278,6 +280,9 @@ module('Acceptance | session-recordings | list', function (hooks) {
     assert.dom(commonSelectors.TABLE_ROWS).isVisible({ count: 2 });
 
     await click(commonSelectors.FILTER_DROPDOWN('scope'));
+    await waitFor(
+      commonSelectors.FILTER_DROPDOWN_ITEM(instances.target.scope.id),
+    );
     await click(
       commonSelectors.FILTER_DROPDOWN_ITEM(instances.target.scope.id),
     );

ui/admin/tests/unit/controllers/scopes/scope/session-recordings/index-test.js

@@ -138,21 +138,5 @@ module(
       assert.strictEqual(controller.page, 1);
       assert.deepEqual(controller.time, last24Hours.toISOString());
     });
-
-    test('refresh action calls refreshAll', async function (assert) {
-      assert.expect(2);
-      controller.set('target', {
-        send(actionName, ...args) {
-          assert.strictEqual(actionName, 'refreshAll');
-          assert.deepEqual(
-            args,
-            [],
-            'refreshAll was called with the correct arguments',
-          );
-        },
-      });
-
-      await controller.refresh();
-    });
   },
 );