Skip to content

Commit e889314

Browse files
committed
refactor: 💡 change inputs to readonly and update submit button
Per a11y audit, this changes the input fields to readonly instead of disabled. It also updates the submit button text so that it is context based and has an aria-label for screenreaders. ✅ Closes: FE-112
1 parent dab0526 commit e889314

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

‎ui/admin/app/components/form/user/index.hbs‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
@value={{@model.name}}
1717
@isInvalid={{@model.errors.name}}
1818
@isOptional={{true}}
19-
disabled={{form.disabled}}
19+
readonly={{form.disabled}}
2020
{{on 'input' (set-from-event @model 'name')}}
2121
as |F|
2222
>
@@ -36,7 +36,7 @@
3636
@value={{@model.description}}
3737
@isInvalid={{@model.errors.description}}
3838
@isOptional={{true}}
39-
disabled={{form.disabled}}
39+
readonly={{form.disabled}}
4040
as |F|
4141
>
4242
<F.Label>{{t 'form.description.label'}}</F.Label>
@@ -52,7 +52,8 @@
5252

5353
{{#if (can 'save model' @model)}}
5454
<form.actions
55-
@enableEditText={{t 'actions.edit-form'}}
55+
@enableEditText={{t 'actions.edit-user-details.button-text'}}
56+
aria-label={{t 'actions.edit-user-details.aria-label'}}
5657
@submitText={{t 'actions.save'}}
5758
@cancelText={{t 'actions.cancel'}}
5859
/>

0 commit comments

Comments
 (0)