Skip to content

add charset #22598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sanikachavan5 merged 4 commits into from
Aug 25, 2025
Merged

add charset #22598

sanikachavan5 merged 4 commits into from
Aug 25, 2025
+43 −41

Conversation

@sanikachavan5
Copy link
Contributor

@sanikachavan5 sanikachavan5 commented Aug 22, 2025 •
edited
Loading

Description

Add explicit charset encoding to prevent attacker from interpreting the output in a different encoding than intended.

Testing & Reproduction steps

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.

  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

  • If applicable, I've documented the impact of any changes to security controls.

    Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

@sanikachavan5 sanikachavan5 requested a review from a team as a code owner August 22, 2025 18:52
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface labels Aug 22, 2025
@sanikachavan5 sanikachavan5 added backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/ent/1.20 backport to ent 1.20 backport/ent/1.21 changes are backported to 1.21 ent theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface and removed theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface labels Aug 22, 2025
@sanikachavan5 sanikachavan5 merged commit 84cdd8b into main Aug 25, 2025
118 checks passed
@sanikachavan5 sanikachavan5 deleted the sanikachavan5/SECVULN-8628-add-charset-wherever-applicable branch August 25, 2025 11:21
@hc-github-team-consul-core hc-github-team-consul-core added the backport/1.21 This release series is longer active on CE, use backport/ent/1.21 label Aug 25, 2025
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Aug 25, 2025
Closed
7 tasks
@sanikachavan5 sanikachavan5 mentioned this pull request Aug 26, 2025
Closed
7 tasks
sanikachavan5 added a commit that referenced this pull request Aug 26, 2025
@sanikachavan5
add charset (#22598)
55390e9 
* add charset

* fix tests

* fix tests
sanikachavan5 added a commit that referenced this pull request Aug 26, 2025
@sanikachavan5
add charset (#22598)
7a7fa7d 
* add charset

* fix tests

* fix tests
@sanikachavan5 sanikachavan5 mentioned this pull request Aug 26, 2025
Merged
7 tasks
sanikachavan5 added a commit that referenced this pull request Aug 26, 2025
@sanikachavan5
Manual Backport of add charset (#22598) (#22629)
a91b3b4 
add charset (#22598)

* add charset

* fix tests

* fix tests
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Sep 8, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

1 similar comment
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Sep 9, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 10, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

29 similar comments
@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 11, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 12, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 13, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 14, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 15, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 16, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 17, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 18, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 19, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 20, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 21, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 23, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 24, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 25, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 26, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 27, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 28, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 29, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 30, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Dec 31, 2025

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 1, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 2, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 3, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 4, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 5, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 6, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 7, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 8, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

@hc-github-team-consul-core
Copy link
Collaborator

hc-github-team-consul-core commented Jan 9, 2026

📣 Hi @sanikachavan5! a backport is missing for this PR [22598] for versions [1.18,1.19,1.20,1.21] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dduzgun-security dduzgun-security dduzgun-security approved these changes

+1 more reviewer

@sriramr98 sriramr98 sriramr98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/ent/1.20 backport to ent 1.20 backport/ent/1.21 changes are backported to 1.21 ent backport/1.21 This release series is longer active on CE, use backport/ent/1.21 theme/api Relating to the HTTP API interface theme/cli Flags and documentation for the CLI interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanikachavan5 @hc-github-team-consul-core @sriramr98 @dduzgun-security